Fix Blocking behavior in Node.js bindings #1156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abdulmth
changed the title
DaughterOfMars
previously approved these changes
Sep 6, 2023
DaughterOfMars
previously approved these changes
Sep 6, 2023
thibault-martinez
previously approved these changes
Sep 6, 2023
Thoralf-M
previously approved these changes
Sep 6, 2023
Alex6323
previously approved these changes
Sep 6, 2023
abdulmth
dismissed stale reviews from Alex6323, Thoralf-M, and thibault-martinez
via
2641bff
thibault-martinez
approved these changes
Sep 6, 2023
Thoralf-M
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1097
Tokio's mpsc channel doesn't work since receiving is async. So I think panic is good enough for now, and it's the same behavior in the old bindings.