Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace neon by napi #1578

Merged
merged 10 commits into from
Nov 6, 2023
Merged

Replace neon by napi #1578

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
b01f787
Replace neon by napi
Thoralf-M Nov 6, 2023
bf43fb3
Remove Nodejs Storage trait test
Thoralf-M Nov 6, 2023
ad86e31
Merge branch '2.0' into napi
Thoralf-M Nov 6, 2023
fa2ffcd
fmt
Thoralf-M Nov 6, 2023
babec4b
Copyright
Thoralf-M Nov 6, 2023
1f19070
Address review comments
Thoralf-M Nov 6, 2023
59bef8d
No quotes
Thoralf-M Nov 6, 2023
e28a224
Missed one
Thoralf-M Nov 6, 2023
15ab784
Rename error variant
Thoralf-M Nov 6, 2023
bf094e2
Merge branch '2.0' into napi
thibault-martinez Nov 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions bindings/nodejs/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,22 +15,22 @@ use napi_derive::napi;
#[non_exhaustive]
pub enum NodejsError {
/// Bindings errors.
#[error("{0}")]
#[error("transparent")]
thibault-martinez marked this conversation as resolved.
Show resolved Hide resolved
Bindings(#[from] iota_sdk_bindings_core::Error),
thibault-martinez marked this conversation as resolved.
Show resolved Hide resolved
/// Client errors.
#[error("{0}")]
#[error("transparent")]
Client(#[from] iota_sdk_bindings_core::iota_sdk::client::Error),
/// Mqtt errors.
#[error("{0}")]
#[error("transparent")]
Mqtt(#[from] iota_sdk_bindings_core::iota_sdk::client::node_api::mqtt::Error),
/// SerdeJson errors.
#[error("{0}")]
#[error("transparent")]
SerdeJson(#[from] serde_json::error::Error),
/// IO error.
#[error("`{0}`")]
#[error("`transparent`")]
Io(#[from] std::io::Error),
/// Wallet errors.
#[error("{0}")]
#[error("transparent")]
Wallet(#[from] iota_sdk_bindings_core::iota_sdk::wallet::Error),
}

Expand Down
6 changes: 4 additions & 2 deletions sdk/src/wallet/error.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,10 @@ pub enum Error {
/// Insufficient funds to send transaction.
#[error("insufficient funds {available}/{required} available")]
InsufficientFunds { available: u64, required: u64 },
/// Invalid event kind.
#[error("invalid event kind: {0}")]
/// Invalid event type.
#[cfg(feature = "events")]
#[cfg_attr(docsrs, doc(cfg(feature = "events")))]
#[error("invalid event type: {0}")]
InvalidEventType(u8),
thibault-martinez marked this conversation as resolved.
Show resolved Hide resolved
/// Invalid mnemonic error
#[error("invalid mnemonic: {0}")]
Expand Down
Loading