Replace neon by napi #1578
Merged
Replace neon by napi #1578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bindings/nodejs/scripts/build.js
Outdated
There was a problem hiding this comment.
I think so, but not 100% sure, don't have something with Windows ready to test
thibault-martinez
approved these changes
Nov 6, 2023
Alex6323
approved these changes
Nov 6, 2023
DaughterOfMars
approved these changes
Nov 6, 2023
This was referenced Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Replace neon by napi. With this we get better error handling, less and cleaner code.
Also might help in the future if we want to implement traits in bindings like this bf43fb3, because it's also easy to await on Promises from the JS side
Type of change
How the change has been tested
Running examples