Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: node merge part 2 #639

Merged
merged 49 commits into from
Jul 5, 2023

Conversation

kwek20
Copy link
Contributor

@kwek20 kwek20 commented Jun 20, 2023

Description of change

Notes from the doc https://hackmd.io/qwysqfJrQvmCzJg2HbWjRg addressed here.

  • MQTT not addressed for the moment.
  • Changed ComputeFoundryId to take an AliasId

todo:

  • Changelog
  • Python plugin_fetch

Links to any relevant issues

Type of change

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Fix

How the change has been tested

Describe the tests that you ran to verify your changes.

Make sure to provide instructions for the maintainer as well as any relevant configurations.

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

Copy link
Member

@thibault-martinez thibault-martinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CHANGELOG entries as it's been released now

Copy link
Member

@Thoralf-M Thoralf-M left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test client::node_api::test_call_plugin_route ... FAILED

Copy link
Member

@thibault-martinez thibault-martinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failing test

DaughterOfMars
DaughterOfMars previously approved these changes Jul 5, 2023
Thoralf-M
Thoralf-M previously approved these changes Jul 5, 2023
DaughterOfMars
DaughterOfMars previously approved these changes Jul 5, 2023
@thibault-martinez thibault-martinez merged commit b1f3c73 into iotaledger:develop Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants