-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: node merge part 2 #639
Merged
thibault-martinez
merged 49 commits into
iotaledger:develop
from
kwek20:feat/node-merge2
Jul 5, 2023
Merged
Changes from 22 commits
Commits
Show all changes
49 commits
Select commit
Hold shift + click to select a range
42ca3eb
added input/output
770e32e
typo, issuer and unit-utils
2147783
utils added
fcac2d8
renamed response to Hash
49642b9
Merge branch 'develop' into feat/node-merge2
f2b1780
added compute to some methods
aed6c52
renamed and added to python
5d887e9
added conflict reason strings and format
c65306b
added plugin_fetch
57fbc09
added to js client
e19dc39
lint
654eba9
format
4762399
lint again :D
00f46f2
removed declare
4e91fcf
Merge branch 'develop' into feat/node-merge2
e9283fd
fixes and mqtt examplue update
a23915a
format and yarn lock
95b3bfb
Merge branch 'develop' into feat/node-merge2
99c2f4b
updated python version req
159e3dc
Merge branch 'develop' into feat/node-merge2
0c1d086
const
bb504c2
review
f8b801c
moved some stuff
a12e9a5
update
5388ca4
review
9053e5b
format
65414f0
changelog and review
269180a
custom_plugin_call
920db2f
Merge branch 'develop' into feat/node-merge2
0c2aabc
changelog
353719b
Merge branch 'develop' into feat/node-merge2
1b33e44
updated test
f63345c
Merge branch 'feat/node-merge2' of https://github.com/kwek20/iota-sdk…
e4580c1
lint
533299e
typo
b1bd101
review
58364d9
review 2
1ea66e3
review 3
9ba4062
review 4
66a4998
just send serde:value
fb104ba
added missing block transforms
9a34719
align comput5e, update test
ef8e7be
fmt
9866d21
made node health ignore actually happen
269dd89
Merge branch 'develop' into feat/node-merge2
739edb2
arghhh
7b5b52f
Merge branch 'feat/node-merge2' of https://github.com/kwek20/iota-sdk…
802f7ec
now without starting /
0db1794
method_path -> endpoint
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a bit confusing given we also have method, maybe endpoint instead? Or something else
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but its also basePluginPath. base_plugin_endpoint as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have a strong opinion, I just don't like method_path
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we changing it then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure ill change method_path to endpoint