Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/izs campus: added 3d map #181

Open
wants to merge 6 commits into
base: kinetic_dev
Choose a base branch
from

Conversation

ipa-fog
Copy link

@ipa-fog ipa-fog commented Mar 5, 2021

Added gazebo map data for the env "izs-campus". The map is based on its 2D gridmap, extruded into 3D space by pkg map2gazebo: https://github.com/shilohc/map2gazebo

<visual name="visual">
<pose>0 0 0 0 0 0</pose>
<geometry>
<mesh filename="package://cob_gazebo_worlds/Media/models/izs-campus/meshes/map.stl" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the mesh file still has 0 Byte (empty file)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very strange, in my repo its not empty (8.9MB). I can also view it here: https://github.com/ipa-fog/cob_simulation/blob/feature/izs-campus/cob_gazebo_worlds/Media/models/izs-campus/meshes/map.stl

Can you access this file as well?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, I can see it there...but honestly, 8.9MB is waaay to large anyway....it will kill gazebo...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as it is a big binary file it should at least be tracked via git-lfs and not be included in the git history to not blow up the repo size. Please check that is not in the history (added and remove) before merging

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reduced the size to 6MB. However, git-lfs is not working because I can't push lfs assets to a public fork unless the original repo already has LFS objects. Therefore, feel free to close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants