Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/izs campus: added 3d map #181

Open
wants to merge 6 commits into
base: kinetic_dev
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file not shown.
4 changes: 2 additions & 2 deletions cob_gazebo_worlds/launch/izs-campus.xml
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,10 @@
<arg name="publish_world_state" value="true"/>

<!-- spawn environment -->
<!--include file="$(find cob_gazebo_worlds)/launch/world_urdf.xml">
<include file="$(find cob_gazebo_worlds)/launch/world_urdf.xml">
<arg name="robot_env" value="$(arg robot_env)"/>
<arg name="publish_world_state" value="$(arg publish_world_state)"/>
</include-->
</include>


</launch>
50 changes: 50 additions & 0 deletions cob_gazebo_worlds/urdf/izs-campus/izs-campus.urdf.xacro
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
<?xml version="1.0"?>
fmessmer marked this conversation as resolved.
Show resolved Hide resolved
<robot xmlns:xacro="http://www.ros.org/wiki/xacro"
name="izs-campus">

<xacro:include filename="$(find cob_gazebo_worlds)/urdf/common.xacro" />
<xacro:include filename="$(find cob_gazebo_worlds)/urdf/materials.urdf.xacro" />

<xacro:macro name="izs-campus" params="name">

<gazebo>
<plugin name="environment_gazebo_ros_control" filename="libgazebo_ros_control.so">
<robotNamespace>world</robotNamespace>
<robotParam>/world_description</robotParam>
</plugin>
</gazebo>

<link name="world"/>

<link name="projected_map">
<xacro:box_inertial x="0.0" y="0.0" z="0.0" mass="5.0">
<origin xyz="0 0 0" rpy="0 0 0" />
</xacro:box_inertial>
<collision name="collision">
<pose>0 0 0 0 0 0</pose>
<geometry>
<mesh filename="package://cob_gazebo_worlds/Media/models/izs-campus/meshes/map.stl" />
</geometry>
</collision>
<visual name="visual">
<pose>0 0 0 0 0 0</pose>
<geometry>
<mesh filename="package://cob_gazebo_worlds/Media/models/izs-campus/meshes/map.stl" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the mesh file still has 0 Byte (empty file)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very strange, in my repo its not empty (8.9MB). I can also view it here: https://github.com/ipa-fog/cob_simulation/blob/feature/izs-campus/cob_gazebo_worlds/Media/models/izs-campus/meshes/map.stl

Can you access this file as well?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, I can see it there...but honestly, 8.9MB is waaay to large anyway....it will kill gazebo...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as it is a big binary file it should at least be tracked via git-lfs and not be included in the git history to not blow up the repo size. Please check that is not in the history (added and remove) before merging

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reduced the size to 6MB. However, git-lfs is not working because I can't push lfs assets to a public fork unless the original repo already has LFS objects. Therefore, feel free to close this PR.

</geometry>
</visual>
</link>

<joint name="joint_maps" type="fixed">
<origin xyz="0.0 0.0 0.0" rpy="0 0 0" />
<parent link="world" />
<child link="projected_map" />
</joint>

<gazebo>
<static>true</static>
</gazebo>

</xacro:macro>
<xacro:izs-campus name="izs-campus" />
</robot>