Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/izs campus: added 3d map #181
base: kinetic_dev
Are you sure you want to change the base?
Feature/izs campus: added 3d map #181
Changes from 5 commits
cfa23d9
192a562
f85f341
24b6c11
49ff21d
e233cf5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the mesh file still has 0 Byte (empty file)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very strange, in my repo its not empty (8.9MB). I can also view it here: https://github.com/ipa-fog/cob_simulation/blob/feature/izs-campus/cob_gazebo_worlds/Media/models/izs-campus/meshes/map.stl
Can you access this file as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, I can see it there...but honestly, 8.9MB is waaay to large anyway....it will kill gazebo...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as it is a big binary file it should at least be tracked via git-lfs and not be included in the git history to not blow up the repo size. Please check that is not in the history (added and remove) before merging
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reduced the size to 6MB. However, git-lfs is not working because I can't push lfs assets to a public fork unless the original repo already has LFS objects. Therefore, feel free to close this PR.