generated from ipfs/ipfs-repository-template
-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
blockservice: move session handling as part of the interface #563
Closed
Jorropo
wants to merge
1
commit into
main
from
01-15-blockservice_move_session_handling_as_part_of_the_interface
Closed
blockservice: move session handling as part of the interface #563
Jorropo
wants to merge
1
commit into
main
from
01-15-blockservice_move_session_handling_as_part_of_the_interface
+77
−104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 15, 2024
Merged
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
This was referenced Jan 15, 2024
Jorropo
force-pushed
the
01-15-blockservice_move_session_handling_as_part_of_the_interface
branch
from
January 15, 2024 12:43
1da7fe3
to
04e1669
Compare
Jorropo
changed the base branch from
blockservice-docs
to
blockservice-stop-using-NewWriteThrough-in-tests
January 15, 2024 12:44
Jorropo
force-pushed
the
01-15-blockservice_move_session_handling_as_part_of_the_interface
branch
from
January 15, 2024 12:44
04e1669
to
b3ef103
Compare
Codecov ReportAttention:
@@ Coverage Diff @@
## main #563 +/- ##
==========================================
- Coverage 65.58% 65.45% -0.13%
==========================================
Files 207 207
Lines 25621 25606 -15
==========================================
- Hits 16803 16760 -43
- Misses 7345 7367 +22
- Partials 1473 1479 +6
|
Jorropo
force-pushed
the
01-15-blockservice_move_session_handling_as_part_of_the_interface
branch
from
January 15, 2024 12:46
b3ef103
to
89e9bce
Compare
Fails to build to due to upstream issues in tests. Gonna fix once we do a decision. |
Jorropo
force-pushed
the
blockservice-stop-using-NewWriteThrough-in-tests
branch
from
January 15, 2024 12:57
afd5403
to
b8ac21b
Compare
Jorropo
force-pushed
the
01-15-blockservice_move_session_handling_as_part_of_the_interface
branch
from
January 15, 2024 12:57
89e9bce
to
739e5e8
Compare
This was referenced Jan 15, 2024
Closed
Base automatically changed from
blockservice-stop-using-NewWriteThrough-in-tests
to
blockservice-opt
January 15, 2024 17:20
Jorropo
force-pushed
the
01-15-blockservice_move_session_handling_as_part_of_the_interface
branch
from
January 15, 2024 17:30
739e5e8
to
a76d47d
Compare
This was referenced Jan 16, 2024
We are going with #570 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See ipfs-shipyard/nopfs#34 (comment)
I'll do changelog one we decide on an option.