Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blockservice: move session handling as part of the interface #563

Conversation

Jorropo
Copy link
Contributor

@Jorropo Jorropo commented Jan 15, 2024

See ipfs-shipyard/nopfs#34 (comment)

I'll do changelog one we decide on an option.

@Jorropo Jorropo marked this pull request as draft January 15, 2024 12:39
@Jorropo Jorropo force-pushed the 01-15-blockservice_move_session_handling_as_part_of_the_interface branch from 1da7fe3 to 04e1669 Compare January 15, 2024 12:43
@Jorropo Jorropo changed the base branch from blockservice-docs to blockservice-stop-using-NewWriteThrough-in-tests January 15, 2024 12:44
@Jorropo Jorropo force-pushed the 01-15-blockservice_move_session_handling_as_part_of_the_interface branch from 04e1669 to b3ef103 Compare January 15, 2024 12:44
Copy link

codecov bot commented Jan 15, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (0536783) 65.58% compared to head (a76d47d) 65.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #563      +/-   ##
==========================================
- Coverage   65.58%   65.45%   -0.13%     
==========================================
  Files         207      207              
  Lines       25621    25606      -15     
==========================================
- Hits        16803    16760      -43     
- Misses       7345     7367      +22     
- Partials     1473     1479       +6     
Files Coverage Δ
fetcher/impl/blockservice/fetcher.go 74.35% <100.00%> (ø)
blockservice/blockservice.go 77.06% <97.36%> (-1.18%) ⬇️
gateway/blocks_backend.go 42.37% <0.00%> (ø)
ipld/merkledag/merkledag.go 76.65% <50.00%> (ø)

... and 16 files with indirect coverage changes

@Jorropo Jorropo force-pushed the 01-15-blockservice_move_session_handling_as_part_of_the_interface branch from b3ef103 to 89e9bce Compare January 15, 2024 12:46
@Jorropo
Copy link
Contributor Author

Jorropo commented Jan 15, 2024

Fails to build to due to upstream issues in tests. Gonna fix once we do a decision.

@Jorropo Jorropo force-pushed the blockservice-stop-using-NewWriteThrough-in-tests branch from afd5403 to b8ac21b Compare January 15, 2024 12:57
@Jorropo Jorropo force-pushed the 01-15-blockservice_move_session_handling_as_part_of_the_interface branch from 89e9bce to 739e5e8 Compare January 15, 2024 12:57
Base automatically changed from blockservice-stop-using-NewWriteThrough-in-tests to blockservice-opt January 15, 2024 17:20
@Jorropo Jorropo deleted the branch main January 15, 2024 17:21
@Jorropo Jorropo closed this Jan 15, 2024
@Jorropo Jorropo reopened this Jan 15, 2024
@Jorropo Jorropo changed the base branch from blockservice-opt to main January 15, 2024 17:24
@Jorropo Jorropo force-pushed the 01-15-blockservice_move_session_handling_as_part_of_the_interface branch from 739e5e8 to a76d47d Compare January 15, 2024 17:30
@Jorropo
Copy link
Contributor Author

Jorropo commented Feb 16, 2024

We are going with #570

@Jorropo Jorropo closed this Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant