blockservice: remove inner fields access methods #564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 15, 2024
Merged
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jan 15, 2024
Jorropo
force-pushed
the
01-15-blockservice_move_session_handling_as_part_of_the_interface
branch
from
1da7fe3
to
04e1669
Compare
Jorropo
force-pushed
the
blockservice-interface-no-inner-fields
branch
from
8de936c
to
c1b8f27
Compare
Jorropo
force-pushed
the
01-15-blockservice_move_session_handling_as_part_of_the_interface
branch
from
04e1669
to
b3ef103
Compare
Jorropo
force-pushed
the
blockservice-interface-no-inner-fields
branch
from
c1b8f27
to
ff49b41
Compare
Codecov ReportAttention:
@@ Coverage Diff @@
## 01-15-blockservice_move_session_handling_as_part_of_the_interface #564 +/- ##
=====================================================================================================
- Coverage 65.45% 65.40% -0.06%
=====================================================================================================
Files 207 207
Lines 25606 25602 -4
=====================================================================================================
- Hits 16760 16744 -16
- Misses 7367 7375 +8
- Partials 1479 1483 +4
|
Jorropo
force-pushed
the
01-15-blockservice_move_session_handling_as_part_of_the_interface
branch
from
b3ef103
to
89e9bce
Compare
Jorropo
force-pushed
the
blockservice-interface-no-inner-fields
branch
from
ff49b41
to
e51c82f
Compare
Jorropo
force-pushed
the
01-15-blockservice_move_session_handling_as_part_of_the_interface
branch
from
89e9bce
to
739e5e8
Compare
Jorropo
force-pushed
the
blockservice-interface-no-inner-fields
branch
from
e51c82f
to
55dc0c2
Compare
This was referenced Jan 15, 2024
Closed
We shouldn't expose inner implementation details of the blockservice to consumers. For example by using the blockstore for the .Has call, the gateway skipped verifcid and blocker checks. Probably fine but not we want to do.
Jorropo
force-pushed
the
01-15-blockservice_move_session_handling_as_part_of_the_interface
branch
from
739e5e8
to
a76d47d
Compare
Jorropo
force-pushed
the
blockservice-interface-no-inner-fields
branch
from
55dc0c2
to
783f4ca
Compare
This was referenced Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'll do changelog once we decide on an option.