Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move DATA* opcodes to the D section #46

Merged
merged 1 commit into from
Jan 24, 2024
Merged

Move DATA* opcodes to the D section #46

merged 1 commit into from
Jan 24, 2024

Conversation

pdobacz
Copy link
Member

@pdobacz pdobacz commented Jan 23, 2024

Closes #43

There is a conflict of EXCHANGE and DATALOAD and the E section is full.

It has been noted the E section could be for Emmediates, but we'd need to separate a bunch of opcodes otherwise related, and would likely run out of opcode slots in E section anyway quite soon.

My quick pitch for the move to D is to instead leave opcodes logically bound to EOF in E leaving plenty of space there for the future. As such, Data and stack lands in D.

Let's quickly gather feedback on this. If there's objections, I'll do an alternative PR to do the Emmediates change and we go with that instead.

Copy link
Contributor

@gumb0 gumb0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this, not very sure we need to move DUPN/SWAPN/EXCHANGE too.

@pdobacz
Copy link
Member Author

pdobacz commented Jan 24, 2024

I'm fine with this, not very sure we need to move DUPN/SWAPN/EXCHANGE too.

OK, let's not move these, one less EIP to update :)

@pdobacz pdobacz changed the title Move DATA* and stack opcodes to the D section Move DATA* opcodes to the D section Jan 24, 2024
@pdobacz pdobacz merged commit bdab8b9 into main Jan 24, 2024
2 checks passed
@pdobacz pdobacz deleted the reorg-opcodes branch January 24, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EXCHANGE Opcode and DATALOAD opcode value collision
2 participants