Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve stream read validation #185

Merged
merged 6 commits into from
Oct 8, 2024
Merged

Improve stream read validation #185

merged 6 commits into from
Oct 8, 2024

Conversation

jeremy-visionaid
Copy link
Collaborator

  • Add/fixes various argument validation for StreamView/StreamDecorator
  • Validate reads in StreamRW
  • Use StreamRW to validate FAT sector chain reads
  • Share StreamRW instances between DirectoryEntry reads/writes

@jeremy-visionaid
Copy link
Collaborator Author

@ironfede These mostly validate the expected amount data is read from streams using StreamRW. i.e., these are things I could cherry-pick out without highlighting where the existing unit tests should fail while working towards fixing #184.

@jeremy-visionaid jeremy-visionaid mentioned this pull request Oct 8, 2024
Closed
@ironfede ironfede merged commit b895a73 into ironfede:master Oct 8, 2024
1 check passed
@jeremy-visionaid jeremy-visionaid mentioned this pull request Oct 13, 2024
Closed
@jeremy-visionaid jeremy-visionaid deleted the validation branch October 16, 2024 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeremy-visionaid @ironfede