Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds nightly action to update VERSION file for pip packaging #1778

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

kellyguo11
Copy link
Contributor

@kellyguo11 kellyguo11 commented Feb 3, 2025

Description

The Isaac Lab pip package requires an update for the VERSION file to trigger a new package build for pypi. This PR adds an automated github action job that runs at 00:00 UTC time every day. The job checks whether any new changes were made to the main branch apps/ or source/ folders on that day and creates a commit to bump the VERSION content if new changes exist.

@Toni-SM
Copy link
Contributor

Toni-SM commented Feb 3, 2025

VERSION increase for Python package should only be applied when there are changes in the source and apps folders.
Changes only in scripts or docs, for example should not update version for Python packages as the package content will remain unchanged.

Also, what happens if we change the version manually? The pipeline will also increase it, and the final version will be the (original) version + 2

@kellyguo11
Copy link
Contributor Author

VERSION increase for Python package should only be applied when there are changes in the source and apps folders. Changes only in scripts or docs, for example should not update version for Python packages as the package content will remain unchanged.

Also, what happens if we change the version manually? The pipeline will also increase it, and the final version will be the (original) version + 2

That's a good point, let me see if we can check for changes in just those 2 folders. I think we should avoid updating VERSION manually if we go with an automated job and only do a manual update for major releases. The automated job should make it easier to maintain rather than having us manually update the VERSION each time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants