Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure HiveLists are treated as non-nullable in hive_generator #728

Merged
merged 2 commits into from
Jul 15, 2021

Conversation

thirdbody
Copy link

@thirdbody thirdbody commented Jul 15, 2021

Resolves error "The argument type 'HiveList?' can't be assigned to the parameter type 'HiveList'.

Closes issue #644.

Resolves error "The argument type 'HiveList<T>?' can't be assigned to the parameter type 'HiveList<T>'.

Closes issue isar#664.
Copy link
Contributor

@themisir themisir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution 😊

What do you think about that?

hive_generator/lib/src/class_builder.dart Outdated Show resolved Hide resolved
@thirdbody
Copy link
Author

Should be good to go now.

@themisir themisir linked an issue Jul 15, 2021 that may be closed by this pull request
@themisir themisir merged commit 413ae35 into isar:master Jul 15, 2021
mrdavidrees pushed a commit to mrdavidrees/hive that referenced this pull request Jan 16, 2022
Ensure HiveLists are treated as non-nullable in hive_generator (isar#728)

* Replaced ?. operator with . operator

Resolves error "The argument type 'HiveList<T>?' can't be assigned to the parameter type 'HiveList<T>'.

Closes issue isar#664.

* Ensuring nullable HiveLists are properly generated

Co-authored-by: Misir Jafarov <[email protected]>

Updated hive_generator dependencies (isar#765)

* Updated dependencies

* Changed version dependencies

Bump up hive_generator to v1.1.1

Get indexDB selectively based on window property (isar#802)

Co-authored-by: Wenhao Wu <[email protected]>

Add missing path parameter to HiveInterface methods (isar#776)

Fixes broken CI (isar#806)

* Update pubspec.yaml

* Migrated from mockito to mocktail

* Test on dart 2.14

Don't loose track of box objects if init crashes (isar#846)

feat: Add flush method to boxes (isar#852)

bump: Update to v2.0.5

Updated hive_generator analyzer dependency (isar#858)

bump up hive_generator to v1.1.2

Change pedantic to linter and fix warnings (isar#876)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Hive generator generates nullable HiveLists
2 participants