Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure HiveLists are treated as non-nullable in hive_generator #728

Merged
merged 2 commits into from
Jul 15, 2021
Merged

Ensure HiveLists are treated as non-nullable in hive_generator #728

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fecc496
Replaced ?. operator with . operator
Jul 15, 2021
778269b
Ensuring nullable HiveLists are properly generated
Jul 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion hive_generator/lib/src/class_builder.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ class ClassBuilder extends Builder {
String _cast(DartType type, String variable) {
var suffix = _suffixFromType(type);
if (hiveListChecker.isAssignableFromType(type)) {
return '($variable as HiveList$suffix)?.castHiveList()';
return '($variable as HiveList$suffix).castHiveList()';
thirdbody marked this conversation as resolved.
Show resolved Hide resolved
} else if (iterableChecker.isAssignableFromType(type) &&
!isUint8List(type)) {
return '($variable as List$suffix)${_castIterable(type)}';
Expand Down