Visualizer: remove glfwTerminate() call from destructor (fix #4960) #4963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes. |
bchretien
commented
Apr 1, 2022
| @@ -193,13 +193,15 @@ bool ViewControl::ConvertFromPinholeCameraParameters( | |||
| bool allow_arbitrary) { | |||
| auto intrinsic = parameters.intrinsic_; | |||
| auto extrinsic = parameters.extrinsic_; | |||
|
|
|||
| constexpr double threshold = 1.e-6; | |||
There was a problem hiding this comment.
Should this be a parameter of the function?
bchretien
force-pushed
the
fix/4960-glfw-terminate
branch
2 times, most recently
from
10b7ff7 to
7753ae0
Compare
bchretien
changed the title
bchretien
changed the title
bchretien
commented
Apr 1, 2022
bchretien
force-pushed
the
fix/4960-glfw-terminate
branch
from
7753ae0 to
c02c810
Compare
bchretien
force-pushed
the
fix/4960-glfw-terminate
branch
from
c02c810 to
0821d31
Compare
bchretien
changed the title
|
Ok PR ready for review! I added some more information in #4960. |
3 tasks
|
Needs testing on all platforms. |
9 tasks
|
Closing this and copying changes to PR #6559 to allow resolving merge conflicts. |
ssheorey
added a commit
that referenced
this pull request
Dec 29, 2023
…(See PR #4963) [Author: @bchretien] (#6559) * examples: fix headless_rendering.py * ViewControl.cpp: relax floating-point comparison in ConvertFromPinholeCameraParameters() * Visualizer: improve GLTF context handling (fix #4960) --------- Authored-by: Benjamin Chrétien <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes:
glfwTerminate()was called everytime aVisualizeris destroyed. Now a true singleton shared context is used, and terminate is only called if there is no remaining activeVisualizer. I also fixedDestroyVisualizerWindow().headless_rendering.py: fix the example.ViewControl::ConvertFromPinholeCameraParameters(): relax the equality check due to floating-point errors.This change is