Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visualizer: remove glfwTerminate() call from destructor (fix #4960) (See PR #4963) [Author: @bchretien] #6559

Merged
merged 4 commits into from
Dec 29, 2023

Conversation

ssheorey
Copy link
Member

This is an update of PR #4963 by @bchretien (original PR did not allow maintainer updates and had a merge conflict).

See PR #4963 for details.

Type

  • Bug fix (non-breaking change which fixes an issue): Fixes glfwTerminate() called in the Visualizer destructor #4960
  • New feature (non-breaking change which adds functionality). Resolves #
  • Breaking change (fix or feature that would cause existing functionality to not work as expected) Resolves #

Motivation and Context

Checklist:

  • I have run python util/check_style.py --apply to apply Open3D code style
    to my code.
  • This PR changes Open3D behavior or adds new functionality.
    • Both C++ (Doxygen) and Python (Sphinx / Google style) documentation is
      updated accordingly.
    • I have added or updated C++ and / or Python unit tests OR included test
      results
      (e.g. screenshots or numbers) here.
  • I will follow up and update the code if CI fails.
  • For fork PRs, I have selected Allow edits from maintainers.

Description

Copy link

update-docs bot commented Dec 29, 2023

Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes.

@ssheorey ssheorey merged commit c948c45 into main Dec 29, 2023
35 of 42 checks passed
@ssheorey ssheorey deleted the fix/4960-glfw-terminate branch December 29, 2023 22:50
@bchretien
Copy link
Contributor

@ssheorey thanks for updating and merging it! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

glfwTerminate() called in the Visualizer destructor
2 participants