Fix log error message for "probability" argument validation in PointCloud::SegmentPlane
#6622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corrected the error message in "cpp/open3d/geometry/PointCloudSegmentation.cpp:PointCloud::SegmentPlane". The message previously read "Probability must be > 0 **or** <= 1.0" whereas it should be "Probability must be > 0 **and** <= 1.0". The message now accurately reflects the expected value for "probability" argument.
|
Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes. |
true-real-michael
changed the title
PointCloud::SegmentPlane
ssheorey
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrected the error message in
cpp/open3d/geometry/PointCloudSegmentation.cpp:PointCloud::SegmentPlane.The
probabilityargument is expected to be between 0 and 1, however log error message does not clearly reflect that.Type
Motivation and Context
Incorrect error message can cause confusion during debugging.
This PR fixes the incorrect error message.
Checklist:
python util/check_style.py --applyto apply Open3D code styleto my code.
updated accordingly.
results (e.g. screenshots or numbers) here.
Description
Argument
probabilityof this function is expected to be between 0 and 1, however if the argument did not satisfy this, the log error message previously read "Probability must be > 0 or <= 1.0" whereas it should be "Probability must be > 0 and <= 1.0". The message now accurately reflects the expected value forprobabilityargument.