feat: adding np.ndarray.var to the frontends #22336

PushpamJha14 · 2023-08-22T12:06:43Z

closes #21949

github-actions · 2023-08-22T12:07:59Z

Thanks for contributing to Ivy! 😊👏
Here are some of the important points from our Contributing Guidelines 📝:
1. Feel free to ignore the run_tests (1), run_tests (2), … jobs, and only look at the display_test_results job. 👀 It contains the following two sections:
- Combined Test Results: This shows the results of all the ivy tests that ran on the PR. ✔️
- New Failures Introduced: This lists the tests that are passing on main, but fail on the PR Fork. Please try to make sure that there are no such tests. 💪
2. The lint / Check formatting / check-formatting tests check for the formatting of your code. 📜 If it fails, please check the exact error message in the logs and fix the same. ⚠️🔧
3. Finally, the test-docstrings / run-docstring-tests check for the changes made in docstrings of the functions. This may be skipped, as well. 📚
Happy coding! 🎉👨‍💻

ivy/functional/frontends/numpy/ndarray/ndarray.py

hello-fri-end

Hey @PushpamJha14 ! Thanks for opening this PR. Just left a few minor comments. Feel free to request another review when you are done with the changes,.

ivy_tests/test_ivy/test_frontends/test_numpy/test_ndarray/test_ndarray.py

hello-fri-end · 2023-08-25T04:40:51Z

ivy_tests/test_ivy/test_frontends/test_numpy/test_ndarray/test_ndarray.py

+        },
+        method_all_as_kwargs_np={
+            "axis": axis,
+            "dtype": "float64",


Why are we hardcoding this?

method_all_as_kwargs_np={
"axis": axis,
}

Is it fine now?

You should write a strategy for generating values for the dtype parameter as well and then add the generated value to this.

hello-fri-end · 2023-08-25T04:45:20Z

ivy_tests/test_ivy/test_frontends/test_numpy/test_ndarray/test_ndarray.py

+@handle_frontend_method(
+    class_tree=CLASS_TREE,
+    init_tree="numpy.array",
+    method_name="var",
+    dtype_x_axis=helpers.dtype_values_axis(
+        available_dtypes=helpers.get_dtypes("float"),


You should generate values for all the parameters of the function, dtype ddof, keepdims and where are missing here.

keepdims=st.booleans(),
where=np_frontend_helpers.where(),
dtype=x=helpers.get_dtypes(kind="integer")
ddof=0

Is it right?

hello-fri-end · 2023-08-25T04:47:16Z

ivy_tests/test_ivy/test_frontends/test_numpy/test_ndarray/test_ndarray.py

+        method_all_as_kwargs_np={
+            "axis": axis,
+            "dtype": "float64",
+            "out": None,


The testing pipeline will take care of testing the out argument, no need to pass that as None here.

method_all_as_kwargs_np={
"axis": axis,
},

Is it fine?

Just remove "out":None

hello-fri-end · 2023-08-28T03:40:18Z

ivy_tests/test_ivy/test_frontends/test_numpy/test_ndarray/test_ndarray.py

+        },
+        method_all_as_kwargs_np={
+            "axis": axis,
+            "dtype": "float64",


You should write a strategy for generating values for the dtype parameter as well and then add the generated value to this.

hello-fri-end · 2023-08-28T03:41:08Z

ivy_tests/test_ivy/test_frontends/test_numpy/test_ndarray/test_ndarray.py

+        method_all_as_kwargs_np={
+            "axis": axis,
+            "dtype": "float64",
+            "out": None,


Just remove "out":None

hello-fri-end

Just a minor comment this time. Would you please resolve the merge conflict and look into the failing test cases? Feel free to request another review whenever you are done 👍

hello-fri-end · 2023-09-01T04:35:33Z

ivy_tests/test_ivy/test_frontends/test_numpy/test_ndarray/test_ndarray.py

+    ),
+    keepdims=st.booleans(),
+    where=np_frontend_helpers.where(),
+    dtype=helpers.get_dtypes(kind="integer"),


Why should this only be integer?

I changed it to valid, is it right now?

hello-fri-end · 2023-09-01T04:43:16Z

ivy_tests/test_ivy/test_frontends/test_numpy/test_ndarray/test_ndarray.py

+    dtype_x_axis=helpers.dtype_values_axis(
+        available_dtypes=helpers.get_dtypes("valid"),
+        valid_axis=True,
+    ),
+    keepdims=st.booleans(),
+    where=np_frontend_helpers.where(),
+    dtype=helpers.get_dtypes(kind="integer"),


You can take a look at the test of the frontend np.var - there's a helper function used there _statistical_dtype_values which you can use to generate the values. It makes sure that the inputs have reasonable bounds and it will also take care of your ddof parameter

to use it I have to import it, is it allowed to import new modules?

PushpamJha14 · 2023-09-03T18:31:54Z

I am not getting how to remove these errors especially lint error, can your please help me

hello-fri-end · 2023-09-09T07:26:52Z

ivy-gardener
✅ Ivy gardener has formatted your code.
If changes are requested, don't forget to pull your fork.

hello-fri-end

Hey @PushpamJha14! Apologies for the delayed response here. ivy-gardener should be able to fix your linting errors. As mentioned in the previous review, could you please update the test to use _statistical_dtype_values to generate the values. Ideally the test should look exactly the same as the corresponding frontend function -- the test for numpy frontend var function is present in /workspaces/ivy/ivy_tests/test_ivy/test_frontends/test_numpy/test_statistics/test_averages_and_variances.py. Happy to clarify any other doubts :)

github-actions

PR Compliance Checks Passed!

hello-fri-end

Hey @PushpamJha14, left a minor comment. Could you make sure the tests are passing locally after the change? Happy to review once again after you are done. Thanks :)

hello-fri-end · 2023-09-16T03:36:32Z

ivy/functional/frontends/numpy/ndarray/ndarray.py

+    def var(
+        self, axis=None, dtype=None, out=None, ddof=0, keepdims=False, *, where=True
+    ):
+        return np_frontend.var(
+            self,
+            axis=axis,
+            dtype=dtype,
+            out=out,
+            ddof=ddof,
+            keepdims=keepdims,
+            where=where,
+        )


Looks like the tests are failing because they are unable to locate this function (https://github.com/unifyai/ivy/actions/runs/6200453935/job/16835349713?pr=22336#step:3:10495). Could you move this function at bit higher up in the file where other numpy nd.array instance methods are implemented?

PushpamJha14 · 2023-09-17T20:03:42Z

hello-fri-end

Thanks for making the changes @PushpamJha14 ! The tests are failing on the CI but the traceback is empty, I have informed the CI team about this. Have you tried to run the test locally?

PushpamJha14 · 2023-09-27T18:37:26Z

I am getting this error

ivy_tests/test_ivy/test_frontends/test_numpy/test_ndarray/test_ndarray.py

…_ndarray.py Co-authored-by: Anwaar Khalid <[email protected]>

PushpamJha14 · 2023-09-29T18:04:34Z

Hi, @hello-fri-end I am still getting the same error and warning

hello-fri-end

There are no failing tests on the CI, will merge this after ivy-gardener fixes the linting errors. Thanks for your contribution @PushpamJha14

Co-authored-by: ivy-branch <[email protected]> Co-authored-by: Anwaar Khalid <[email protected]>

ivy-seed assigned hello-fri-end Aug 22, 2023

ivy-leaves added the NumPy Frontend Developing the NumPy Frontend, checklist triggered by commenting add_frontend_checklist label Aug 22, 2023

hello-fri-end reviewed Aug 25, 2023

View reviewed changes

ivy/functional/frontends/numpy/ndarray/ndarray.py Outdated Show resolved Hide resolved

hello-fri-end suggested changes Aug 25, 2023

View reviewed changes

hello-fri-end suggested changes Aug 28, 2023

View reviewed changes

PushpamJha14 closed this Aug 28, 2023

PushpamJha14 force-pushed the main-1 branch from 96f5464 to 06e97a5 Compare August 28, 2023 14:54

PushpamJha14 reopened this Aug 28, 2023

PushpamJha14 requested a review from hello-fri-end August 28, 2023 15:05

hello-fri-end suggested changes Sep 1, 2023

View reviewed changes

PushpamJha14 closed this Sep 1, 2023

PushpamJha14 force-pushed the main-1 branch from 36555e3 to 07a0326 Compare September 1, 2023 08:16

PushpamJha14 added 2 commits September 1, 2023 13:47

Update ndarray.py

320bb5b

Update test_ndarray.py

2793ff8

PushpamJha14 reopened this Sep 1, 2023

Update test_ndarray.py

2f3cc4d

PushpamJha14 requested a review from hello-fri-end September 3, 2023 18:32

🤖 Lint code

0db2d6f

hello-fri-end suggested changes Sep 9, 2023

View reviewed changes

Update test_ndarray.py

27c41b1

github-actions bot reviewed Sep 15, 2023

View reviewed changes

PushpamJha14 added 4 commits September 15, 2023 15:56

Update test_ndarray.py

d6a707a

Update test_ndarray.py

58355f4

Update test_ndarray.py

d704637

Update test_ndarray.py

321c35b

PushpamJha14 requested a review from hello-fri-end September 15, 2023 16:21

hello-fri-end changed the title ~~Update ndarray.py~~ Adding np.ndarray.var to the frontends Sep 16, 2023

hello-fri-end suggested changes Sep 16, 2023

View reviewed changes

Update ndarray.py

1877638

PushpamJha14 requested a review from hello-fri-end September 17, 2023 19:20

hello-fri-end changed the title ~~Adding np.ndarray.var to the frontends~~ feat: adding np.ndarray.var to the frontends Sep 21, 2023

hello-fri-end reviewed Sep 21, 2023

View reviewed changes

hello-fri-end suggested changes Sep 28, 2023

View reviewed changes

ivy_tests/test_ivy/test_frontends/test_numpy/test_ndarray/test_ndarray.py Outdated Show resolved Hide resolved

Update ivy_tests/test_ivy/test_frontends/test_numpy/test_ndarray/test…

2163214

…_ndarray.py Co-authored-by: Anwaar Khalid <[email protected]>

PushpamJha14 requested a review from hello-fri-end September 29, 2023 18:04

hello-fri-end approved these changes Oct 1, 2023

View reviewed changes

hello-fri-end merged commit 2bfb19a into ivy-llc:main Oct 4, 2023
224 of 269 checks passed

druvdub pushed a commit to druvdub/ivy that referenced this pull request Oct 14, 2023

feat: adding np.ndarray.var to the frontends (ivy-llc#22336)

f3f8b36

Co-authored-by: ivy-branch <[email protected]> Co-authored-by: Anwaar Khalid <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: adding np.ndarray.var to the frontends #22336

feat: adding np.ndarray.var to the frontends #22336

PushpamJha14 commented Aug 22, 2023

github-actions bot commented Aug 22, 2023

hello-fri-end left a comment

hello-fri-end Aug 25, 2023

PushpamJha14 Aug 25, 2023

hello-fri-end Aug 28, 2023

hello-fri-end Aug 25, 2023

PushpamJha14 Aug 25, 2023

hello-fri-end Aug 25, 2023

PushpamJha14 Aug 25, 2023

hello-fri-end Aug 28, 2023

hello-fri-end Aug 28, 2023

hello-fri-end Aug 28, 2023

hello-fri-end left a comment

hello-fri-end Sep 1, 2023

PushpamJha14 Sep 3, 2023

hello-fri-end Sep 1, 2023

PushpamJha14 Sep 3, 2023

PushpamJha14 commented Sep 3, 2023

hello-fri-end commented Sep 9, 2023 •

edited by ivy-branch

Loading

hello-fri-end left a comment

github-actions bot left a comment •

edited

Loading

hello-fri-end left a comment •

edited

Loading

hello-fri-end Sep 16, 2023

PushpamJha14 commented Sep 17, 2023

hello-fri-end left a comment

PushpamJha14 commented Sep 27, 2023

PushpamJha14 commented Sep 29, 2023

hello-fri-end left a comment •

edited

Loading

feat: adding np.ndarray.var to the frontends #22336

feat: adding np.ndarray.var to the frontends #22336

Conversation

PushpamJha14 commented Aug 22, 2023

github-actions bot commented Aug 22, 2023

hello-fri-end left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hello-fri-end left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

PushpamJha14 commented Sep 3, 2023

hello-fri-end commented Sep 9, 2023 • edited by ivy-branch Loading

hello-fri-end left a comment

Choose a reason for hiding this comment

github-actions bot left a comment • edited Loading

Choose a reason for hiding this comment

hello-fri-end left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

PushpamJha14 commented Sep 17, 2023

hello-fri-end left a comment

Choose a reason for hiding this comment

PushpamJha14 commented Sep 27, 2023

PushpamJha14 commented Sep 29, 2023

hello-fri-end left a comment • edited Loading

Choose a reason for hiding this comment

hello-fri-end commented Sep 9, 2023 •

edited by ivy-branch

Loading

github-actions bot left a comment •

edited

Loading

hello-fri-end left a comment •

edited

Loading

hello-fri-end left a comment •

edited

Loading