Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding np.ndarray.var to the frontends #22336

Merged
merged 11 commits into from
Oct 4, 2023
Merged

feat: adding np.ndarray.var to the frontends #22336

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
320bb5b
Update ndarray.py
PushpamJha14 Sep 1, 2023
2793ff8
Update test_ndarray.py
PushpamJha14 Sep 1, 2023
2f3cc4d
Update test_ndarray.py
PushpamJha14 Sep 3, 2023
0db2d6f
🤖 Lint code
ivy-branch Sep 9, 2023
27c41b1
Update test_ndarray.py
PushpamJha14 Sep 15, 2023
d6a707a
Update test_ndarray.py
PushpamJha14 Sep 15, 2023
58355f4
Update test_ndarray.py
PushpamJha14 Sep 15, 2023
d704637
Update test_ndarray.py
PushpamJha14 Sep 15, 2023
321c35b
Update test_ndarray.py
PushpamJha14 Sep 15, 2023
1877638
Update ndarray.py
PushpamJha14 Sep 16, 2023
2163214
Update ivy_tests/test_ivy/test_frontends/test_numpy/test_ndarray/test…
PushpamJha14 Sep 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions ivy/functional/frontends/numpy/ndarray/ndarray.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -723,3 +723,16 @@ def _unsigned_int_bytes_repr(item_val, /, *, dtype=None):
return b"".join(bytes_reprs)
else:
raise ValueError("Unsupported data type for the array.")

def var(
self, axis=None, dtype=None, out=None, ddof=0, keepdims=False, *, where=True
):
return np_frontend.var(
self,
axis=axis,
dtype=dtype,
out=out,
ddof=ddof,
keepdims=keepdims,
where=where,
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the tests are failing because they are unable to locate this function (https://github.com/unifyai/ivy/actions/runs/6200453935/job/16835349713?pr=22336#step:3:10495). Could you move this function at bit higher up in the file where other numpy nd.array instance methods are implemented?

49 changes: 49 additions & 0 deletions ivy_tests/test_ivy/test_frontends/test_numpy/test_ndarray/test_ndarray.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,9 @@
assert_all_close,
BackendHandler,
)
from ivy_tests.test_ivy.test_functional.test_core.test_statistical import (
_statistical_dtype_values,
)
import ivy_tests.test_ivy.test_frontends.test_numpy.helpers as np_frontend_helpers
from ivy_tests.test_ivy.test_functional.test_core.test_linalg import (
_get_first_matrix_and_dtype,
Expand Down Expand Up @@ -3638,6 +3641,52 @@ def test_numpy_ndarray_transpose(
)


# var
@handle_frontend_method(
class_tree=CLASS_TREE,
init_tree="numpy.array",
method_name="var",
dtype_x_axis=_statistical_dtype_values(function="var"),
keepdims=st.booleans(),
where=np_frontend_helpers.where(),
dtype=helpers.get_dtypes(kind="valid"),
)
def test_numpy_ndarray_var(
dtype_x_axis,
frontend_method_data,
init_flags,
method_flags,
frontend,
backend_fw,
on_device,
keepdims,
where,
dtype,
):
input_dtypes, x, axis = dtype_x_axis
helpers.test_frontend_method(
init_input_dtypes=input_dtypes,
method_input_dtypes=input_dtypes,
init_all_as_kwargs_np={
"object": x[0],
},
method_all_as_kwargs_np={
"axis": axis,
"dtype": dtype,
"keepdims": keepdims,
"where": where,
},
frontend=frontend,
backend_to_test=backend_fw,
frontend_method_data=frontend_method_data,
init_flags=init_flags,
method_flags=method_flags,
rtol_=1e-2,
atol_=1e-2,
on_device=on_device,
)


# view
@handle_frontend_method(
class_tree=CLASS_TREE,
Expand Down
Loading