-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Random sampling to Numpy Frontend: logseries #22719
Conversation
Thanks for contributing to Ivy! 😊👏 |
Frontend Task ChecklistIMPORTANT NOTICE 🚨:The Ivy Docs represent the ground truth for the task descriptions and this checklist should only be used as a supplementary item to aid with the review process. Please note that the contributor is not expected to understand everything in the checklist. It's mainly here for the reviewer to make sure everything has been done correctly 🙂 LEGEND 🗺:
CHECKS 📑:
|
ivy-gardener |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Tanzeel161,
I've added some comments that I would like you to address. After that we can run the final tests
ivy_tests/test_ivy/test_frontends/test_numpy/test_random/test_functions.py
Outdated
Show resolved
Hide resolved
ivy_tests/test_ivy/test_frontends/test_numpy/test_random/test_functions.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, merging now 😄
Co-authored-by: ivy-branch <[email protected]> Reviewed-by: KareemMAX <[email protected]> Refs: ivy-llc#22719
Co-authored-by: ivy-branch <[email protected]> Reviewed-by: KareemMAX <[email protected]> Refs: ivy-llc#22719
PR Description
Related Issue
Close #21402
Checklist
Socials: