-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added few more checks
to enhance the codebase.
#22974
Conversation
Thanks for contributing to Ivy! 😊👏 |
If you are working on an open task, please edit the PR description to link to the issue you've created. For more information, please check ToDo List Issues Guide. Thank you 🤗 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Sai-Suraj-27,
LGTM! But sadly there are some conflicts, maybe we can coordinate the merge privately as lint merges are often time sensitive. Feel free to hit me on Discord.
2eaff07
to
555d710
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Sai-Suraj-27,
Awesome work, sorry I had to rewrite the git history in order to resolve conflicts 😅. I'll add you as a co-author as you did all of the work ofc.
checks
to enhance the codebase.
checks
to enhance the codebase.checks
to enhance the codebase.
Co-authored-by: Kareem Morsy <[email protected]>
PR Description
Updated the
.pre-commit-config.yaml
file by adding few more simple checks. These checks are very common and used in many bigPython
based organizations including scikit-learn, mindsbd, jax, pandas, etc.Added the following pre-commit hooks
These checks can be used to make the code in the repository more clean, readable and better.
Checklist
Socials: