Code

Fix torch svd#28770

Code

Open

Daniel4078 wants to merge 43 commits intoivy-llc:mainivy-llc/ivy:mainfrom Daniel4078:fix-torch-frontend-blas_and_lapack_ops.svdDaniel4078/ivy:fix-torch-frontend-blas_and_lapack_ops.svdCopy head branch name to clipboard

+471-197

Commits

Commits on Jun 20, 2024

• fixed the potentially wrong namedtuple definitions in the svd backend functions,

  Show description for f7f499e
  

  Jin Wang

  committed
  f7f499e

  Copy full SHA for f7f499e

• try to fix the blas_and_lapack_ops.py.svd with correct output namedtuple definition and behavior when compute_uv is false

  

  Jin Wang

  committed
  3db7f17

  Copy full SHA for 3db7f17

• try to fix the blas_and_lapack_ops.py.svd with correct output namedtuple definition and behavior when compute_uv is false

  

  Jin Wang

  committed
  46d180a

  Copy full SHA for 46d180a

Commits on Jun 30, 2024

• replace the unimplemented tensor.mH used to the implemented adjoint, fixed the wrong shape and dtype of return. Now there are somehow numerial difference between return of groundtruth torch.svd and…

  Show description for dce10a6
  

  Jin Wang

  committed
  dce10a6

  Copy full SHA for dce10a6

Commits on Jul 3, 2024

• update test of torch.blas_and_lapack_ops.svd to calculate the validity of result instead of matching values

  

  Jin Wang

  committed
  0c13ce6

  Copy full SHA for 0c13ce6

• small fix

  

  Jin Wang

  committed
  4d0851d

  Copy full SHA for 4d0851d

• small fix

  

  Jin Wang

  committed
  3b3670f

  Copy full SHA for 3b3670f

• updated the test for torch.linalg.svd

  

  Jin Wang

  committed
  71fed6b

  Copy full SHA for 71fed6b

• find that jax.lax.linalg.svd has a argument "subset_by_index" missing

  

  Jin Wang

  committed
  3fdf4dd

  Copy full SHA for 3fdf4dd

• fixed the skipping torch svd tests according to suggestion, no longer skipping

  

  Jin Wang

  committed
  c5b5904

  Copy full SHA for c5b5904

Commits on Jul 4, 2024

• tests are partially passing, though for torch backend, "RuntimeError: Can't call numpy() on Tensor that requires grad. Use tensor.detach().numpy() instead.

  Show description for efe9a5a
  

  Jin Wang

  committed
  efe9a5a

  Copy full SHA for efe9a5a

Commits on Jul 7, 2024

• fix test of numpy.linalg.decomposition.svd as it returns a svd object instead of the normal tuple and apply the np.asarray(x) change over ivy.as_numpy in other tests, ensure the different return pa…

  Show description for 26aeba0
  

  Jin Wang

  committed
  26aeba0

  Copy full SHA for 26aeba0

Commits on Jul 14, 2024

• Merge branch 'ivy-llc:main' into fix-torch-frontend-blas_and_lapack_ops.svd

  Daniel4078

  authored
  b9cf1cd

  Copy full SHA for b9cf1cd

Commits on Jul 15, 2024

• now only torch backend of jax.numpy.linalg.svd is failing due to "RuntimeError: Can't call numpy() on Tensor that requires grad. Use tensor.detach().numpy() instead." when the test function calls n…

  Show description for 3bb5b66
  

  Jin Wang

  committed
  3bb5b66

  Copy full SHA for 3bb5b66

• all tests for tesnorflow.linalg.svd are passing

  

  Jin Wang

  committed
  8b29eb7

  Copy full SHA for 8b29eb7

Commits on Jul 16, 2024

• try to fix the two svd function in torch frontend, now the only problem is that the ground truth returns a ivy array with dtype the same as input, while the function returns a torch tensor with the…

  Show description for bc30d7d
  

  Jin Wang

  committed
  bc30d7d

  Copy full SHA for bc30d7d

• applied the suggested fix to torch svd tests, they are all passing now

  

  Jin Wang

  committed
  bed8f77

  Copy full SHA for bed8f77

• make namedtuple definition more simple as suggested

  

  Jin Wang

  committed
  316986e

  Copy full SHA for 316986e

• tried to fix jax.lac.linalg.svd. p.s. there is no implementation of subset_by_index parameter. tensorflow,torch and paddle backends are all failing due to significant value differences in only part…

  Show description for e0268c6
  

  Jin Wang

  committed
  e0268c6

  Copy full SHA for e0268c6

• fixed jax.numpy.linalg.svd, all tests are passing, but jax.lax.linalg.svd produces significant difference with compute_uv=True (like flipped signs) in the reconstructed matrixes for all backends. I…

  Show description for dcab2c1
  

  Jin Wang

  committed
  dcab2c1

  Copy full SHA for dcab2c1

Commits on Jul 18, 2024

• Merge branch 'ivy-llc:main' into fix-torch-frontend-blas_and_lapack_ops.svd

  Daniel4078

  authored
  da4a78b

  Copy full SHA for da4a78b

• fixing numpy.linalg.decompositions.svd

  

  Jin Wang

  committed
  ac7a60a

  Copy full SHA for ac7a60a

Commits on Jul 31, 2024

• Merge branch 'ivy-llc:main' into fix-torch-frontend-blas_and_lapack_ops.svd

  Daniel4078

  authored
  9b4c161

  Copy full SHA for 9b4c161

Commits on Aug 12, 2024

• Merge branch 'ivy-llc:main' into fix-torch-frontend-blas_and_lapack_ops.svd

  Daniel4078

  authored
  6c1c39c

  Copy full SHA for 6c1c39c

Commits on Aug 16, 2024

• fixed ivy_tests/test_ivy/test_frontends/test_torch/test_tensor.py::test_torch_svd, all tests passed

  

  Jin Wang

  committed
  8e927a4

  Copy full SHA for 8e927a4

• fixed ivy_tests/test_ivy/test_frontends/test_numpy/test_linalg/test_decompositions.py::test_numpy_svd, though seems like using ivy.astype to convert type does not work at all

  

  Jin Wang

  committed
  37272a8

  Copy full SHA for 37272a8

Commits on Aug 18, 2024

• Fixing ivy_tests/test_ivy/test_frontends/test_tensorflow/test_raw_ops.py::test_tensorflow_Svd, now the frontend somehow always return float64 nomatter input dtype

  

  Jin Wang

  committed
  dc90073

  Copy full SHA for dc90073

Commits on Aug 20, 2024

• fixed ivy_tests/test_ivy/test_frontends/test_jax/test_numpy/test_linalg.py::test_jax_svd

  

  Jin Wang

  committed
  65c902f

  Copy full SHA for 65c902f

• fixing ivy_tests/test_ivy/test_frontends/test_tensorflow/test_raw_ops.py::test_tensorflow_Svd, though if input is complex number the results show large difference

  

  Jin Wang

  committed
  c92b6be

  Copy full SHA for c92b6be

Commits on Aug 22, 2024

• changed ivy_tests/test_ivy/test_frontends/test_torch/test_blas_and_lapack_ops.py::test_torch_svd so that complex number inputs are also tested, they are passing

  

  Jin Wang

  committed
  c1a6632

  Copy full SHA for c1a6632

• changed all the torch's test_torch_svd so that complex number inputs are also tested, they are all passing

  

  Jin Wang

  committed
  9b75cd1

  Copy full SHA for 9b75cd1

• try to update torch and tensorflow's svd functions as they somehow return fixed dtypes depending on if input is complex,

  

  Jin Wang

  committed
  5c9de15

  Copy full SHA for 5c9de15

• seems like should not use svdvals as it always return a not complex value instead as the same as the input, but the documents shows that the S component will always be real, which is different from…

  Show description for 2f76f66
  

  Jin Wang

  committed
  2f76f66

  Copy full SHA for 2f76f66

Commits on Aug 23, 2024

• fixed jax's svd to teat for complex input. though only jax.lax.linalg.svd fail for tensorflow backend due to significant and updated all relavent svd with more complex supported dtype

  

  Jin Wang

  committed
  412e60c

  Copy full SHA for 412e60c

Commits on Aug 28, 2024

• Merge branch 'ivy-llc:main' into fix-torch-frontend-blas_and_lapack_ops.svd

  Daniel4078

  authored
  ee58d83

  Copy full SHA for ee58d83

Commits on Sep 3, 2024

• Merge branch 'ivy-llc:main' into fix-torch-frontend-blas_and_lapack_ops.svd

  Daniel4078

  authored
  9433e91

  Copy full SHA for 9433e91

Commits on Sep 6, 2024

• Merge branch 'ivy-llc:main' into fix-torch-frontend-blas_and_lapack_ops.svd

  Daniel4078

  authored
  c7d9ddc

  Copy full SHA for c7d9ddc

Commits on Sep 28, 2024

• Merge branch 'ivy-llc:main' into fix-torch-frontend-blas_and_lapack_ops.svd

  Daniel4078

  authored
  c89223c

  Copy full SHA for c89223c

• small update on test_torch.test_tensor.test_torch_svd

  Daniel4078

  authored
  99b7266

  Copy full SHA for 99b7266

• Update test_blas_and_lapack_ops.py

  Daniel4078

  authored
  00f7754

  Copy full SHA for 00f7754

• Update test_linalg.py

  Daniel4078

  authored
  49db616

  Copy full SHA for 49db616

Commits on Sep 30, 2024

• Update test_linalg.py

  Daniel4078

  authored
  637652e

  Copy full SHA for 637652e

• Update test_tensor.py

  Daniel4078

  authored
  390b00b

  Copy full SHA for 390b00b