try to fix the blas_and_lapack_ops.py.svd with correct output namedtu…

…ple definition and behavior when compute_uv is false

ivy/functional/frontends/torch/blas_and_lapack_ops.py

@@ -2,6 +2,7 @@
 import ivy
 from ivy.func_wrapper import with_unsupported_dtypes
 import ivy.functional.frontends.torch as torch_frontend
+from collections import namedtuple
 from ivy.functional.frontends.torch.func_wrapper import to_ivy_arrays_and_back
 
 
@@ -191,11 +192,16 @@ def slogdet(A, *, out=None):
 
 @to_ivy_arrays_and_back
 def svd(input, some=True, compute_uv=True, *, out=None):
-    # TODO: add compute_uv
-    if some:
-        ret = ivy.svd(input, full_matrices=False)
+    # TODO: add handling for driver
+    ret = ivy.svd(input, full_matrices=not some, compute_uv=compute_uv)
+    results = namedtuple("svd", ['U', 'S', 'V'])
+    if compute_uv:
+        ret = results(ret.U, ret.S, ret.Vh.mH)
     else:
-        ret = ivy.svd(input, full_matrices=True)
+        shape = input.shape
+        m = shape[-2]
+        n = shape[-1]
+        ret = results(ivy.zeros((m,m)), ret.S, ivy.zeros((n,n))) # TODO: keep the zeros on same device as input
     if ivy.exists(out):
         return ivy.inplace_update(out, ret)
     return ret

ivy/functional/frontends/torch/linalg.py

@@ -326,8 +326,11 @@ def solve_ex(A, B, *, left=True, check_errors=False, out=None):
     {"2.2 and below": ("float32", "float64", "complex32", "complex64")}, "torch"
 )
 def svd(A, /, *, full_matrices=True, driver=None, out=None):
-    # TODO: add handling for driver and out
-    return ivy.svd(A, compute_uv=True, full_matrices=full_matrices)
+    # TODO: add handling for driver
+    ret = ivy.svd(A, compute_uv=True, full_matrices=full_matrices)
+    if ivy.exists(out):
+        return ivy.inplace_update(out, ret)
+    return ret
 
 
 @to_ivy_arrays_and_back