fixes agda#2458

jamesmckinna · Aug 29, 2024 · 9d310ab · 9d310ab
1 parent 355ac25
commit 9d310ab
Show file tree

Hide file tree

Showing 9 changed files with 27 additions and 16 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -24,6 +24,11 @@ Deprecated modules
 Deprecated names
 ----------------
 
+* In `Algebra.Morphism.Structures`:
+  ```agda
+  homo  ↦  ∙-homo
+  ```
+
 * In `Data.Vec.Properties`:
   ```agda
   ++-assoc _      ↦  ++-assoc-eqFree

diff --git a/src/Algebra/Lattice/Morphism/Structures.agda b/src/Algebra/Lattice/Morphism/Structures.agda
@@ -58,13 +58,13 @@ module LatticeMorphisms (L₁ : RawLattice a ℓ₁) (L₂ : RawLattice b ℓ₂
     ∧-isMagmaHomomorphism : ∧.IsMagmaHomomorphism ⟦_⟧
     ∧-isMagmaHomomorphism = record
       { isRelHomomorphism = isRelHomomorphism
-      ; homo = ∧-homo
+      ; ∙-homo = ∧-homo
       }
 
     ∨-isMagmaHomomorphism : ∨.IsMagmaHomomorphism ⟦_⟧
     ∨-isMagmaHomomorphism = record
       { isRelHomomorphism = isRelHomomorphism
-      ; homo = ∨-homo
+      ; ∙-homo = ∨-homo
       }
 
   record IsLatticeMonomorphism (⟦_⟧ : A → B) : Set (a ⊔ ℓ₁ ⊔ ℓ₂) where

diff --git a/src/Algebra/Morphism/Construct/Initial.agda b/src/Algebra/Morphism/Construct/Initial.agda
@@ -51,7 +51,7 @@ isMagmaHomomorphism : (M : RawMagma m ℓm) →
                       IsMagmaHomomorphism rawMagma M zero
 isMagmaHomomorphism M = record
   { isRelHomomorphism = record { cong = cong (RawMagma._≈_ M) }
-  ; homo = λ()
+  ; ∙-homo = λ()
   }
 
 isMagmaMonomorphism : (M : RawMagma m ℓm) →

diff --git a/src/Algebra/Morphism/Construct/Terminal.agda b/src/Algebra/Morphism/Construct/Terminal.agda
@@ -50,7 +50,7 @@ isMagmaHomomorphism : (M : RawMagma a ℓa) →
                       IsMagmaHomomorphism M rawMagma one
 isMagmaHomomorphism M = record
   { isRelHomomorphism = record { cong = _ }
-  ; homo = _
+  ; ∙-homo = _
   }
 
 isMonoidHomomorphism : (M : RawMonoid a ℓa) →

diff --git a/src/Algebra/Morphism/Structures.agda b/src/Algebra/Morphism/Structures.agda
@@ -83,7 +83,14 @@ module MagmaMorphisms (M₁ : RawMagma a ℓ₁) (M₂ : RawMagma b ℓ₂) wher
   record IsMagmaHomomorphism (⟦_⟧ : A → B) : Set (a ⊔ ℓ₁ ⊔ ℓ₂) where
     field
       isRelHomomorphism : IsRelHomomorphism _≈₁_ _≈₂_ ⟦_⟧
-      homo              : Homomorphic₂ ⟦_⟧ _∙_ _◦_
+      ∙-homo              : Homomorphic₂ ⟦_⟧ _∙_ _◦_
+
+      -- Deprecated.
+    homo = ∙-homo
+    {-# WARNING_ON_USAGE homo
+    "Warning: homo was deprecated in v2.2.
+    Please use ∙-homo instead. "
+    #-}
 
     open IsRelHomomorphism isRelHomomorphism public
       renaming (cong to ⟦⟧-cong)
@@ -200,7 +207,6 @@ module GroupMorphisms (G₁ : RawGroup a ℓ₁) (G₂ : RawGroup b ℓ₂) wher
       injective           : Injective _≈₁_ _≈₂_ ⟦_⟧
 
     open IsGroupHomomorphism isGroupHomomorphism public
-      renaming (homo to ∙-homo)
 
     isMonoidMonomorphism : IsMonoidMonomorphism ⟦_⟧
     isMonoidMonomorphism = record
@@ -265,7 +271,7 @@ module NearSemiringMorphisms (R₁ : RawNearSemiring a ℓ₁) (R₂ : RawNearSe
     *-isMagmaHomomorphism : *.IsMagmaHomomorphism ⟦_⟧
     *-isMagmaHomomorphism = record
       { isRelHomomorphism = isRelHomomorphism
-      ; homo = *-homo
+      ; ∙-homo = *-homo
       }
 
   record IsNearSemiringMonomorphism (⟦_⟧ : A → B) : Set (a ⊔ ℓ₁ ⊔ ℓ₂) where
@@ -430,7 +436,7 @@ module RingWithoutOneMorphisms (R₁ : RawRingWithoutOne a ℓ₁) (R₂ : RawRi
     *-isMagmaHomomorphism : *.IsMagmaHomomorphism ⟦_⟧
     *-isMagmaHomomorphism = record
       { isRelHomomorphism = isRelHomomorphism
-      ; homo = *-homo
+      ; ∙-homo = *-homo
       }
 
   record IsRingWithoutOneMonomorphism (⟦_⟧ : A → B) : Set (a ⊔ ℓ₁ ⊔ ℓ₂) where
@@ -623,19 +629,19 @@ module QuasigroupMorphisms (Q₁ : RawQuasigroup a ℓ₁) (Q₂ : RawQuasigroup
     ∙-isMagmaHomomorphism : ∙.IsMagmaHomomorphism ⟦_⟧
     ∙-isMagmaHomomorphism = record
       { isRelHomomorphism = isRelHomomorphism
-      ; homo = ∙-homo
+      ; ∙-homo = ∙-homo
       }
 
     \\-isMagmaHomomorphism : \\.IsMagmaHomomorphism ⟦_⟧
     \\-isMagmaHomomorphism = record
       { isRelHomomorphism  = isRelHomomorphism
-      ; homo = \\-homo
+      ; ∙-homo = \\-homo
       }
 
     //-isMagmaHomomorphism : //.IsMagmaHomomorphism ⟦_⟧
     //-isMagmaHomomorphism = record
       { isRelHomomorphism  = isRelHomomorphism
-      ; homo = //-homo
+      ; ∙-homo = //-homo
       }
 
   record IsQuasigroupMonomorphism (⟦_⟧ : A → B) : Set (a ⊔ ℓ₁ ⊔ ℓ₂) where

diff --git a/src/Data/List/Properties.agda b/src/Data/List/Properties.agda
@@ -229,7 +229,7 @@ module _ (A : Set a) where
     { isRelHomomorphism = record
       { cong = cong length
       }
-    ; homo = λ xs ys → length-++ xs {ys}
+    ; ∙-homo = λ xs ys → length-++ xs {ys}
     }
 
   length-isMonoidHomomorphism : IsMonoidHomomorphism (++-[]-rawMonoid A) +-0-rawMonoid length

diff --git a/src/Data/Parity/Properties.agda b/src/Data/Parity/Properties.agda
@@ -422,7 +422,7 @@ toSign-isMagmaHomomorphism : IsMagmaHomomorphism ℙ.+-rawMagma 𝕊.*-rawMagma
 toSign-isMagmaHomomorphism = record
   { isRelHomomorphism = record
     { cong = cong toSign }
-  ; homo = +-homo-*
+  ; ∙-homo = +-homo-*
   }
 
 toSign-isMagmaMonomorphism : IsMagmaMonomorphism ℙ.+-rawMagma 𝕊.*-rawMagma toSign
@@ -532,7 +532,7 @@ parity-isMagmaHomomorphism : IsMagmaHomomorphism ℕ.+-rawMagma ℙ.+-rawMagma p
 parity-isMagmaHomomorphism = record
   { isRelHomomorphism = record
     { cong = cong parity }
-  ; homo = +-homo-+
+  ; ∙-homo = +-homo-+
   }
 
 parity-isMonoidHomomorphism : IsMonoidHomomorphism ℕ.+-0-rawMonoid ℙ.+-0-rawMonoid parity

diff --git a/src/Function/Endo/Propositional.agda b/src/Function/Endo/Propositional.agda
@@ -111,7 +111,7 @@ module _ (f : Endo) where
   ^-isMagmaHomomorphism : IsMagmaHomomorphism +-rawMagma ∘-rawMagma (f ^_)
   ^-isMagmaHomomorphism = record
     { isRelHomomorphism = record { cong = cong (f ^_) }
-    ; homo = ^-homo
+    ; ∙-homo = ^-homo
     }
 
   ^-isMonoidHomomorphism : IsMonoidHomomorphism +-0-rawMonoid ∘-id-rawMonoid (f ^_)

diff --git a/src/Function/Endo/Setoid.agda b/src/Function/Endo/Setoid.agda
@@ -106,7 +106,7 @@ module _ (f : Endo) where
   ^-isMagmaHomomorphism : IsMagmaHomomorphism +-rawMagma ∘-rawMagma (f ^_)
   ^-isMagmaHomomorphism = record
     { isRelHomomorphism = record { cong = ^-cong₂ }
-    ; homo = ^-homo
+    ; ∙-homo = ^-homo
     }
 
   ^-isMonoidHomomorphism : IsMonoidHomomorphism +-0-rawMonoid ∘-id-rawMonoid (f ^_)