fix: dune bootstrap #53
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason, dune's bootstrap process doesn't like
enabling CAML_INTERNALS. See the error in CI:
```
cd _boot && /Users/runner/work/dune/dune/_opam/bin/ocamlopt.opt -c -g -I +unix -I +threads spawn_stubs.c
vendor/spawn/src/spawn_stubs.c:481:20: error: implicit declaration of function 'caml_convert_signal_number' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
int signal = caml_convert_signal_number(Long_val(Field(v_signals_list, 0)));
^
1 error generated.
```
I'm not sure why, but it's easy enough to workaround it be declaring the
function that we need.
It's also a little cleaner this way as we only make the one private
function we need available rather than everything.
Signed-off-by: Rudi Grinberg <[email protected]>
<!-- ps-id: cfe43bbb-bb8a-4289-a102-594ae6f6945d -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, dune's bootstrap process doesn't like
enabling CAML_INTERNALS. See the error in CI:
I'm not sure why, but it's easy enough to workaround it be declaring the
function that we need.
It's also a little cleaner this way as we only make the one private
function we need available rather than everything.
Signed-off-by: Rudi Grinberg [email protected]