Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dune bootstrap #53

Closed
wants to merge 1 commit into from
Closed

fix: dune bootstrap #53

wants to merge 1 commit into from

Commits on Sep 26, 2023

  1. fix: dune bootstrap

    For some reason, dune's bootstrap process doesn't like
    enabling CAML_INTERNALS. See the error in CI:
    
    ```
    cd _boot && /Users/runner/work/dune/dune/_opam/bin/ocamlopt.opt -c -g -I +unix -I +threads spawn_stubs.c
    vendor/spawn/src/spawn_stubs.c:481:20: error: implicit declaration of function 'caml_convert_signal_number' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
          int signal = caml_convert_signal_number(Long_val(Field(v_signals_list, 0)));
                       ^
    1 error generated.
    ```
    
    I'm not sure why, but it's easy enough to workaround it be declaring the
    function that we need.
    
    It's also a little cleaner this way as we only make the one private
    function we need available rather than everything.
    
    Signed-off-by: Rudi Grinberg <[email protected]>
    
    <!-- ps-id: cfe43bbb-bb8a-4289-a102-594ae6f6945d -->
    rgrinberg committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    76496d9 View commit details
    Browse the repository at this point in the history