Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent FORMS_URLFIELD_ASSUME_HTTPS warning on Django 5.0 #384

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

adamchainz
Copy link
Contributor

Prevent this warning:

$ python -Wall manage.py help
/.../django/conf/__init__.py:214: RemovedInDjango60Warning: The FORMS_URLFIELD_ASSUME_HTTPS transitional setting is deprecated.
  warnings.warn(
...

The approach of listing the setting in deprecated_settings is the same as for STORAGES in #349, but it does not need to be conditional.

@adamchainz adamchainz force-pushed the deprecated_form_setting branch from 3cc5e8f to fe4903c Compare May 9, 2024 10:10
@adamchainz
Copy link
Contributor Author

Tests are passing but Codecov is failing to upload:

[2024-05-09T10:11:52.172Z] ['error'] There was an error running the uploader: Error uploading to https://codecov.io: Error: There was an error fetching the storage URL during POST: 429 - {'detail': ErrorDetail(string='Rate limit reached. Please upload with the Codecov repository upload token to resolve issue. Expected time to availability: 925s.', code='throttled')}

I think this needs an admin to reinstall the app or grab a token from codecov.io. Or we could ditch codecov per https://hynek.me/articles/ditch-codecov-python/ - that’s what I did for my open source projects.

@pauloxnet
Copy link
Member

Tests are passing but Codecov is failing to upload:

[2024-05-09T10:11:52.172Z] ['error'] There was an error running the uploader: Error uploading to https://codecov.io: Error: There was an error fetching the storage URL during POST: 429 - {'detail': ErrorDetail(string='Rate limit reached. Please upload with the Codecov repository upload token to resolve issue. Expected time to availability: 925s.', code='throttled')}

I think this needs an admin to reinstall the app or grab a token from codecov.io. Or we could ditch codecov per https://hynek.me/articles/ditch-codecov-python/ - that’s what I did for my open source projects.

Thanks @adamchainz I opened an issue about that #390

Copy link
Member

@pauloxnet pauloxnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@uhurusurfa
Copy link
Contributor

@pauloxnet - do you have permissions to rebase this PR so it reruns the tests now that the codecov issue is resolved?

@uhurusurfa
Copy link
Contributor

@pauloxnet - can you also confirm if you have been given full maintainer permissions on this project yet please

@pauloxnet pauloxnet requested a review from uhurusurfa November 8, 2024 15:31
@pauloxnet
Copy link
Member

@pauloxnet - can you also confirm if you have been given full maintainer permissions on this project yet please

@uhurusurfa please avoid tagging me 2 times in 1 minute in 2 separate comments, as I already wrote I don't have full maintainer permission and I can't access the settings or force a rebase.

In future when you tag me in an issue please wait for a response, I'll try to reply when I'll find the free time to do that, it can be days, I understand your enthusiasm, but this is a total volunteer and unpaid job for me, and I can't assure any time of response or unlimited amount of time in it.

In the alternative, tag other maintainers, or apply to be part of the project.

@uhurusurfa
Copy link
Contributor

@pauloxnet - can you also confirm if you have been given full maintainer permissions on this project yet please

@uhurusurfa please avoid tagging me 2 times in 1 minute in 2 separate comments, as I already wrote I don't have full maintainer permission and I can't access the settings or force a rebase.

In future when you tag me in an issue please wait for a response, I'll try to reply when I'll find the free time to do that, it can be days, I understand your enthusiasm, but this is a total volunteer and unpaid job for me, and I can't assure any time of response or unlimited amount of time in it.

In the alternative, tag other maintainers, or apply to be part of the project.

Fair enough. I will try alternative roputes

Copy link
Contributor

@uhurusurfa uhurusurfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@adamchainz adamchainz force-pushed the deprecated_form_setting branch from fe4903c to b8e94fd Compare November 18, 2024 11:37
@adamchainz
Copy link
Contributor Author

Rebased.

Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.39%. Comparing base (f37ed87) to head (b8e94fd).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #384   +/-   ##
=======================================
  Coverage   90.39%   90.39%           
=======================================
  Files          25       25           
  Lines        1197     1197           
  Branches       86       86           
=======================================
  Hits         1082     1082           
  Misses         88       88           
  Partials       27       27           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@uhurusurfa uhurusurfa merged commit 0bf4161 into jazzband:master Nov 18, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants