-
-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Django 4.1 and 4.2 support #127
Conversation
@@ -7,3 +7,5 @@ | |||
] | |||
|
|||
SECRET_KEY = "spam-eggs" | |||
|
|||
USE_TZ = True |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fixes the Django 4.0+ warning:
django.utils.deprecation.RemovedInDjango50Warning: The default value of USE_TZ will change from False to True in Django 5.0. Set USE_TZ to False in your project settings if you want to keep the current default behavior.
ref https://docs.djangoproject.com/en/4.0/releases/4.0/#time-zone-support
Added Django 4.2 to this PR. |
LGTM. Also fixes the import issue in a better way than I did in #136 . Just need to fix the linting errors on the py310-djqa test. Will have a look tomorrow. |
Codecov Report
@@ Coverage Diff @@
## master #127 +/- ##
=======================================
Coverage 89.85% 89.85%
=======================================
Files 2 2
Lines 138 138
Branches 18 18
=======================================
Hits 124 124
Misses 9 9
Partials 5 5 see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
I discovered which files to change by checking the last Django version update: 593fa02