Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Django 4.1 and 4.2 support #127

Merged
merged 2 commits into from
Aug 24, 2023
Merged

Conversation

adamchainz
Copy link
Contributor

@adamchainz adamchainz commented Aug 25, 2022

I discovered which files to change by checking the last Django version update: 593fa02

@@ -7,3 +7,5 @@
]

SECRET_KEY = "spam-eggs"

USE_TZ = True
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the Django 4.0+ warning:

django.utils.deprecation.RemovedInDjango50Warning: The default value of USE_TZ will change from False to True in Django 5.0. Set USE_TZ to False in your project settings if you want to keep the current default behavior.

ref https://docs.djangoproject.com/en/4.0/releases/4.0/#time-zone-support

@adamchainz adamchainz changed the title Add Django 4.1 support Add Django 4.1 and 4.2 support Apr 24, 2023
@adamchainz
Copy link
Contributor Author

Added Django 4.2 to this PR.

@georgek
Copy link
Contributor

georgek commented Aug 23, 2023

LGTM. Also fixes the import issue in a better way than I did in #136 . Just need to fix the linting errors on the py310-djqa test. Will have a look tomorrow.

@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Merging #127 (30b60a8) into master (40fc72d) will not change coverage.
The diff coverage is n/a.

❗ Current head 30b60a8 differs from pull request most recent head f7b67d7. Consider uploading reports for the commit f7b67d7 to get more accurate results

@@           Coverage Diff           @@
##           master     #127   +/-   ##
=======================================
  Coverage   89.85%   89.85%           
=======================================
  Files           2        2           
  Lines         138      138           
  Branches       18       18           
=======================================
  Hits          124      124           
  Misses          9        9           
  Partials        5        5           

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@georgek georgek self-requested a review August 24, 2023 19:07
@georgek georgek merged commit f7b67d7 into jazzband:master Aug 24, 2023
26 checks passed
@adamchainz adamchainz deleted the django_4.1 branch October 25, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants