[hotfix] cmake_dependent_option requires CMake 3.25 #251

uilianries · 2024-02-14T15:25:55Z

Hello!

We are packaging the version 0.11 in Conan and we found an error related to cmake_dependent_option when building on Linux. It's possible to reproduce it locally, but basically, does not matter what option value you pass when running CMake <3.25, it will always use the forced negative value. For instance:

$ cat /etc/lsb-release 
DISTRIB_ID=Ubuntu
DISTRIB_RELEASE=16.04
DISTRIB_CODENAME=xenial
DISTRIB_DESCRIPTION="Ubuntu 16.04.7 LTS"

$ cmake --version
cmake version 3.24.3

$ cmake --preset debug-shared
Preset CMake variables:

  CMAKE_BUILD_TYPE="Debug"
  CMAKE_TOOLCHAIN_FILE="/home/conan/project/build/conan/conan_toolchain.cmake"
  CMAKE_VERBOSE_MAKEFILE="ON"
  LIBCORO_BUILD_EXAMPLES="ON"
  LIBCORO_BUILD_SHARED_LIBS="ON"
  LIBCORO_BUILD_TESTS="ON"
  LIBCORO_EXTERNAL_DEPENDENCIES="ON"
  LIBCORO_FEATURE_NETWORKING="ON"
  LIBCORO_FEATURE_TLS="ON"

-- Using Conan toolchain: /home/conan/project/build/conan/conan_toolchain.cmake
-- Conan toolchain: C++ Standard 20 with extensions OFF
-- The CXX compiler identification is GNU 11.1.0
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/local/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
libcoro LIBCORO_EXTERNAL_DEPENDENCIES = ON
libcoro LIBCORO_BUILD_TESTS           = ON
libcoro LIBCORO_CODE_COVERAGE         = OFF
libcoro LIBCORO_BUILD_EXAMPLES        = ON
libcoro LIBCORO_FEATURE_NETWORKING    = OFF
libcoro LIBCORO_FEATURE_TLS           = OFF
libcoro LIBCORO_RUN_GITCONFIG         = OFF
libcoro LIBCORO_BUILD_SHARED_LIBS     = ON
-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY
-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success
-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY
-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success
-- Performing Test COMPILER_HAS_DEPRECATED_ATTR
-- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success
-- The C compiler identification is GNU 11.1.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /usr/local/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Configuring done
-- Generating done
-- Build files have been written to: /home/conan/project/build/debug-shared

As you can see, LIBCORO_FEATURE_TLS is configured to be ON, but results in OFF. The code is clear about the condition:

cmake_dependent_option(LIBCORO_FEATURE_TLS "Include TLS encryption features, Default=ON." ON "NOT EMSCRIPTEN; LINUX" OFF)

If Not Emscripten AND Is Linux ... That's my current scenario. Still, does not work.

Now using CMake 3.25:

$ cmake --version
cmake version 3.25.0

$ cmake --preset debug-shared
Preset CMake variables:

  CMAKE_BUILD_TYPE="Debug"
  CMAKE_TOOLCHAIN_FILE="/home/conan/project/build/conan/conan_toolchain.cmake"
  CMAKE_VERBOSE_MAKEFILE="ON"
  LIBCORO_BUILD_EXAMPLES="ON"
  LIBCORO_BUILD_SHARED_LIBS="ON"
  LIBCORO_BUILD_TESTS="ON"
  LIBCORO_EXTERNAL_DEPENDENCIES="ON"
  LIBCORO_FEATURE_NETWORKING="ON"
  LIBCORO_FEATURE_TLS="ON"

-- Using Conan toolchain: /home/conan/project/build/conan/conan_toolchain.cmake
-- Conan toolchain: C++ Standard 20 with extensions OFF
-- The CXX compiler identification is GNU 11.1.0
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/local/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
libcoro LIBCORO_EXTERNAL_DEPENDENCIES = ON
libcoro LIBCORO_BUILD_TESTS           = ON
libcoro LIBCORO_CODE_COVERAGE         = OFF
libcoro LIBCORO_BUILD_EXAMPLES        = ON
libcoro LIBCORO_FEATURE_NETWORKING    = ON
libcoro LIBCORO_FEATURE_TLS           = ON
libcoro LIBCORO_RUN_GITCONFIG         = OFF
libcoro LIBCORO_BUILD_SHARED_LIBS     = ON
-- Conan: Component target declared 'c-ares::cares'
-- Conan: Component target declared 'OpenSSL::Crypto'
-- Conan: Component target declared 'OpenSSL::SSL'
-- Conan: Target declared 'openssl::openssl'
-- Conan: Target declared 'ZLIB::ZLIB'
-- Conan: Including build module from '/home/conan/.conan2/p/b/opens8c4125cc29df4/p/lib/cmake/conan-official-openssl-variables.cmake'
-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY
-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success
-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY
-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success
-- Performing Test COMPILER_HAS_DEPRECATED_ATTR
-- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success
-- The C compiler identification is GNU 11.1.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /usr/local/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Configuring done
-- Generating done
-- Build files have been written to: /home/conan/project/build/debug-shared

Now it works when running CMake 2.25. I changed nothing related to the project, only the CMake version.

My guess is some CMP changed in 3.25 which affects cmake_dependent_option.

Signed-off-by: Uilian Ries <[email protected]>

uilianries · 2024-02-14T15:35:22Z

Checking the 0.11 in Github action:

The option for TLS is ON:
https://github.com/jbaldwin/libcoro/actions/runs/7879263120/job/21499183890?pr=250#step:5:10

But, the configuration results as OFF:
https://github.com/jbaldwin/libcoro/actions/runs/7879263120/job/21499183890?pr=250#step:5:26

And it's Ubuntu.

jbaldwin · 2024-02-14T15:36:10Z

Might make sense to revert out the change that is causing this and rework that PR since it looks like cmaked 3.25 isn't available on a lot of the CI runs out of the box. And then probably a v0.11.1 release without it?

Side question, would it make sense to have a GitHub action that triggers on release to build for Conan?

jbaldwin · 2024-02-14T15:46:21Z

#252

I believe this should resolve the bug, I will subsequently be opening another PR to try an reinvestigate this.

jbaldwin · 2024-02-14T15:47:18Z

Would you mind giving that branch a try with the conan build process to verify its working properly?

Signed-off-by: Uilian Ries <[email protected]>

uilianries · 2024-02-14T16:07:24Z

Would you mind giving that branch a try with the conan build process to verify its working properly?

Yes, give me some minutes. I'll test here and post the result.

Might make sense to revert out the change that is causing this and rework that PR since it looks like cmaked 3.25 isn't available on a lot of the CI runs out of the box. And then probably a v0.11.1 release without it?

Yes, please. In Conan we had some resistance to move to 3.15. Now imagine 3.23 ...

Side question, would it make sense to have a GitHub action that triggers on release to build for Conan?

Not needed, usually users push a new package as soon they require :)

jbaldwin · 2024-02-14T16:07:55Z

https://github.com/jbaldwin/libcoro/releases/tag/v0.11.1

jbaldwin · 2024-02-14T16:09:09Z

Thanks for reporting the bug, and sorry for the problem! The change seemed harmless but clearly it needs some more testing around it. I'm about to head out skiing for the day so I'll check back in later to make sure everything on v0.11.1 is working well.

uilianries · 2024-02-14T16:12:13Z

Working with Conan:

$ conan create all --version=0.11 -s compiler.cppstd=20 -s build_type=Debug 

======== Exporting recipe to the cache ========
libcoro/0.11: Exporting package recipe: /home/conan/project/all/conanfile.py
libcoro/0.11: exports: File 'conandata.yml' found. Exporting it...
libcoro/0.11: Calling export_sources()
libcoro/0.11: Copied 1 '.yml' file: conandata.yml
libcoro/0.11: Copied 1 '.py' file: conanfile.py
libcoro/0.11: Exported to cache folder: /home/conan/.conan2/p/libcof243009a19db9/e
libcoro/0.11: Exported: libcoro/0.11#c8785ea7de8cb6eb0c525b109ebde276 (2024-02-14 16:11:07 UTC)

======== Input profiles ========
Profile host:
[settings]
arch=x86_64
build_type=Debug
compiler=gcc
compiler.cppstd=20
compiler.libcxx=libstdc++11
compiler.version=11
os=Linux

Profile build:
[settings]
arch=x86_64
build_type=Release
compiler=gcc
compiler.cppstd=gnu17
compiler.libcxx=libstdc++11
compiler.version=11
os=Linux


======== Computing dependency graph ========
Graph root
    cli
Requirements
    c-ares/1.25.0#b55eb90f63e256cfd7272b912b681258 - Cache
    libcoro/0.11#c8785ea7de8cb6eb0c525b109ebde276 - Cache
    openssl/3.2.1#39bd48ed31f1f3fbdcd75a0648aaedcf - Cache
    tl-expected/1.1.0#beaea6a1c8d4e2ec7985524fbe8967fd - Cache
    zlib/1.3.1#af8f2ef3d8e0fddf1975281d7fe43bf6 - Cache
Resolved version ranges
    openssl/[>=1.1 <4]: openssl/3.2.1
    zlib/[>=1.2.11 <2]: zlib/1.3.1

======== Computing necessary packages ========
libcoro/0.11: Forced build from source
Requirements
    c-ares/1.25.0#b55eb90f63e256cfd7272b912b681258:2835c450acc09f3f265ad1a0c30b019fa2b06585#f545b3a32b170f19c26bd88b2d7e1619 - Cache
    libcoro/0.11#c8785ea7de8cb6eb0c525b109ebde276:1e8144e18dbd4a4c38f943470166650dae9e25b1 - Build
    openssl/3.2.1#39bd48ed31f1f3fbdcd75a0648aaedcf:7f4ff40bbfc1a5f62f937c537336b6e3297317c4#c2cf584bb569607060d35552250ec5a5 - Cache
    tl-expected/1.1.0#beaea6a1c8d4e2ec7985524fbe8967fd:da39a3ee5e6b4b0d3255bfef95601890afd80709#8009cbea1e813f9f9258a2f49dc12c81 - Cache
    zlib/1.3.1#af8f2ef3d8e0fddf1975281d7fe43bf6:659f5046bee3c5a8463ca82f0ce7aaba50748d87#795601090c402b6f0eb88c524400d24d - Cache

======== Installing packages ========
c-ares/1.25.0: Already installed! (1 of 5)
tl-expected/1.1.0: Already installed! (2 of 5)
zlib/1.3.1: Already installed! (3 of 5)
openssl/3.2.1: Already installed! (4 of 5)
libcoro/0.11: Calling source() in /home/conan/.conan2/p/libcof243009a19db9/s/src
libcoro/0.11: Unzipping 1.5MB, this can take a while
Unzipping 100 %                                                       

-------- Installing package libcoro/0.11 (5 of 5) --------
libcoro/0.11: Building from source
libcoro/0.11: Package libcoro/0.11:1e8144e18dbd4a4c38f943470166650dae9e25b1
libcoro/0.11: Copying sources to build folder
libcoro/0.11: Building your package in /home/conan/.conan2/p/b/libcob7eabca8441d5/b
libcoro/0.11: Calling generate()
libcoro/0.11: Generators folder: /home/conan/.conan2/p/b/libcob7eabca8441d5/b/build/Debug/generators
libcoro/0.11: CMakeToolchain generated: conan_toolchain.cmake
libcoro/0.11: CMakeToolchain generated: CMakePresets.json
libcoro/0.11: CMakeToolchain generated: ../../../src/CMakeUserPresets.json
libcoro/0.11: Generating aggregated env files
libcoro/0.11: Generated aggregated env files: ['conanbuild.sh', 'conanrun.sh']
libcoro/0.11: Calling build()
libcoro/0.11: Running CMake.configure()
libcoro/0.11: RUN: cmake -G "Unix Makefiles" -DCMAKE_TOOLCHAIN_FILE="/home/conan/.conan2/p/b/libcob7eabca8441d5/b/build/Debug/generators/conan_toolchain.cmake" -DCMAKE_INSTALL_PREFIX="/home/conan/.conan2/p/b/libcob7eabca8441d5/p" -DCMAKE_POLICY_DEFAULT_CMP0091="NEW" -DCMAKE_BUILD_TYPE="Debug" "/home/conan/.conan2/p/b/libcob7eabca8441d5/b/src"
-- Using Conan toolchain: /home/conan/.conan2/p/b/libcob7eabca8441d5/b/build/Debug/generators/conan_toolchain.cmake
-- Conan toolchain: Setting CMAKE_POSITION_INDEPENDENT_CODE=ON (options.fPIC)
-- Conan toolchain: C++ Standard 20 with extensions OFF
-- Conan toolchain: Setting BUILD_SHARED_LIBS = OFF
-- The CXX compiler identification is GNU 11.1.0
-- Check for working CXX compiler: /usr/local/bin/c++
-- Check for working CXX compiler: /usr/local/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
libcoro LIBCORO_EXTERNAL_DEPENDENCIES = ON
libcoro LIBCORO_BUILD_TESTS           = OFF
libcoro LIBCORO_CODE_COVERAGE         = OFF
libcoro LIBCORO_BUILD_EXAMPLES        = OFF
libcoro LIBCORO_FEATURE_NETWORKING    = True
libcoro LIBCORO_FEATURE_TLS           = True
libcoro LIBCORO_RUN_GITCONFIG         = OFF
libcoro LIBCORO_BUILD_SHARED_LIBS     = False
-- Conan: Component target declared 'c-ares::cares'
-- Conan: Component target declared 'OpenSSL::Crypto'
-- Conan: Component target declared 'OpenSSL::SSL'
-- Conan: Target declared 'openssl::openssl'
-- Conan: Target declared 'ZLIB::ZLIB'
-- Conan: Including build module from '/home/conan/.conan2/p/b/opens86765aa91692a/p/lib/cmake/conan-official-openssl-variables.cmake'
-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY
-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success
-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY
-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success
-- Performing Test COMPILER_HAS_DEPRECATED_ATTR
-- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success
-- Configuring done
-- Generating done
CMake Warning:
  Manually-specified variables were not used by the project:

    CMAKE_POLICY_DEFAULT_CMP0091


-- Build files have been written to: /home/conan/.conan2/p/b/libcob7eabca8441d5/b/build/Debug

libcoro/0.11: Running CMake.build()
libcoro/0.11: RUN: cmake --build "/home/conan/.conan2/p/b/libcob7eabca8441d5/b/build/Debug" -- -j10
Scanning dependencies of target libcoro
[ 17%] Building CXX object CMakeFiles/libcoro.dir/src/sync_wait.cpp.o
[ 17%] Building CXX object CMakeFiles/libcoro.dir/src/event.cpp.o
[ 17%] Building CXX object CMakeFiles/libcoro.dir/src/io_scheduler.cpp.o
[ 21%] Building CXX object CMakeFiles/libcoro.dir/src/thread_pool.cpp.o
[ 21%] Building CXX object CMakeFiles/libcoro.dir/src/semaphore.cpp.o
[ 26%] Building CXX object CMakeFiles/libcoro.dir/src/mutex.cpp.o
[ 34%] Building CXX object CMakeFiles/libcoro.dir/src/net/connect.cpp.o
[ 34%] Building CXX object CMakeFiles/libcoro.dir/src/net/ip_address.cpp.o
[ 39%] Building CXX object CMakeFiles/libcoro.dir/src/net/dns/resolver.cpp.o
[ 43%] Building CXX object CMakeFiles/libcoro.dir/src/poll.cpp.o
[ 47%] Building CXX object CMakeFiles/libcoro.dir/src/net/recv_status.cpp.o
[ 52%] Building CXX object CMakeFiles/libcoro.dir/src/net/send_status.cpp.o
[ 56%] Building CXX object CMakeFiles/libcoro.dir/src/net/socket.cpp.o
[ 60%] Building CXX object CMakeFiles/libcoro.dir/src/net/tcp/client.cpp.o
[ 65%] Building CXX object CMakeFiles/libcoro.dir/src/net/tcp/server.cpp.o
[ 69%] Building CXX object CMakeFiles/libcoro.dir/src/net/udp/peer.cpp.o
[ 73%] Building CXX object CMakeFiles/libcoro.dir/src/net/tls/client.cpp.o
[ 78%] Building CXX object CMakeFiles/libcoro.dir/src/net/tls/connection_status.cpp.o
[ 82%] Building CXX object CMakeFiles/libcoro.dir/src/net/tls/context.cpp.o
[ 86%] Building CXX object CMakeFiles/libcoro.dir/src/net/tls/send_status.cpp.o
[ 91%] Building CXX object CMakeFiles/libcoro.dir/src/net/tls/recv_status.cpp.o
[ 95%] Building CXX object CMakeFiles/libcoro.dir/src/net/tls/server.cpp.o
[100%] Linking CXX static library libcoro.a
[100%] Built target libcoro

libcoro/0.11: Package '1e8144e18dbd4a4c38f943470166650dae9e25b1' built
libcoro/0.11: Build folder /home/conan/.conan2/p/b/libcob7eabca8441d5/b/build/Debug
libcoro/0.11: Generating the package
libcoro/0.11: Packaging in folder /home/conan/.conan2/p/b/libcob7eabca8441d5/p
libcoro/0.11: Calling package()
libcoro/0.11: Running CMake.install()
libcoro/0.11: RUN: cmake --install "/home/conan/.conan2/p/b/libcob7eabca8441d5/b/build/Debug" --prefix "/home/conan/.conan2/p/b/libcob7eabca8441d5/p"
-- Install configuration: "Debug"
-- Installing: /home/conan/.conan2/p/b/libcob7eabca8441d5/p/lib/libcoro.a
-- Installing: /home/conan/.conan2/p/b/libcob7eabca8441d5/p/include/coro
-- Installing: /home/conan/.conan2/p/b/libcob7eabca8441d5/p/include/coro/generator.hpp
-- Installing: /home/conan/.conan2/p/b/libcob7eabca8441d5/p/include/coro/attribute.hpp
-- Installing: /home/conan/.conan2/p/b/libcob7eabca8441d5/p/include/coro/thread_pool.hpp
-- Installing: /home/conan/.conan2/p/b/libcob7eabca8441d5/p/include/coro/latch.hpp
-- Installing: /home/conan/.conan2/p/b/libcob7eabca8441d5/p/include/coro/fd.hpp
-- Installing: /home/conan/.conan2/p/b/libcob7eabca8441d5/p/include/coro/semaphore.hpp
-- Installing: /home/conan/.conan2/p/b/libcob7eabca8441d5/p/include/coro/task_container.hpp
-- Installing: /home/conan/.conan2/p/b/libcob7eabca8441d5/p/include/coro/shared_mutex.hpp
-- Installing: /home/conan/.conan2/p/b/libcob7eabca8441d5/p/include/coro/coro.hpp
-- Installing: /home/conan/.conan2/p/b/libcob7eabca8441d5/p/include/coro/event.hpp
-- Installing: /home/conan/.conan2/p/b/libcob7eabca8441d5/p/include/coro/ring_buffer.hpp
-- Installing: /home/conan/.conan2/p/b/libcob7eabca8441d5/p/include/coro/detail
-- Installing: /home/conan/.conan2/p/b/libcob7eabca8441d5/p/include/coro/detail/poll_info.hpp
-- Installing: /home/conan/.conan2/p/b/libcob7eabca8441d5/p/include/coro/detail/tl_expected.hpp
-- Installing: /home/conan/.conan2/p/b/libcob7eabca8441d5/p/include/coro/detail/void_value.hpp
-- Installing: /home/conan/.conan2/p/b/libcob7eabca8441d5/p/include/coro/mutex.hpp
-- Installing: /home/conan/.conan2/p/b/libcob7eabca8441d5/p/include/coro/sync_wait.hpp
-- Installing: /home/conan/.conan2/p/b/libcob7eabca8441d5/p/include/coro/io_scheduler.hpp
-- Installing: /home/conan/.conan2/p/b/libcob7eabca8441d5/p/include/coro/concepts
-- Installing: /home/conan/.conan2/p/b/libcob7eabca8441d5/p/include/coro/concepts/executor.hpp
-- Installing: /home/conan/.conan2/p/b/libcob7eabca8441d5/p/include/coro/concepts/buffer.hpp
-- Installing: /home/conan/.conan2/p/b/libcob7eabca8441d5/p/include/coro/concepts/awaitable.hpp
-- Installing: /home/conan/.conan2/p/b/libcob7eabca8441d5/p/include/coro/concepts/range_of.hpp
-- Installing: /home/conan/.conan2/p/b/libcob7eabca8441d5/p/include/coro/concepts/promise.hpp
-- Installing: /home/conan/.conan2/p/b/libcob7eabca8441d5/p/include/coro/expected.hpp
-- Installing: /home/conan/.conan2/p/b/libcob7eabca8441d5/p/include/coro/net
-- Installing: /home/conan/.conan2/p/b/libcob7eabca8441d5/p/include/coro/net/ip_address.hpp
-- Installing: /home/conan/.conan2/p/b/libcob7eabca8441d5/p/include/coro/net/recv_status.hpp
-- Installing: /home/conan/.conan2/p/b/libcob7eabca8441d5/p/include/coro/net/socket.hpp
-- Installing: /home/conan/.conan2/p/b/libcob7eabca8441d5/p/include/coro/net/dns
-- Installing: /home/conan/.conan2/p/b/libcob7eabca8441d5/p/include/coro/net/dns/resolver.hpp
-- Installing: /home/conan/.conan2/p/b/libcob7eabca8441d5/p/include/coro/net/udp
-- Installing: /home/conan/.conan2/p/b/libcob7eabca8441d5/p/include/coro/net/udp/peer.hpp
-- Installing: /home/conan/.conan2/p/b/libcob7eabca8441d5/p/include/coro/net/connect.hpp
-- Installing: /home/conan/.conan2/p/b/libcob7eabca8441d5/p/include/coro/net/tcp
-- Installing: /home/conan/.conan2/p/b/libcob7eabca8441d5/p/include/coro/net/tcp/client.hpp
-- Installing: /home/conan/.conan2/p/b/libcob7eabca8441d5/p/include/coro/net/tcp/server.hpp
-- Installing: /home/conan/.conan2/p/b/libcob7eabca8441d5/p/include/coro/net/hostname.hpp
-- Installing: /home/conan/.conan2/p/b/libcob7eabca8441d5/p/include/coro/net/tls
-- Installing: /home/conan/.conan2/p/b/libcob7eabca8441d5/p/include/coro/net/tls/recv_status.hpp
-- Installing: /home/conan/.conan2/p/b/libcob7eabca8441d5/p/include/coro/net/tls/client.hpp
-- Installing: /home/conan/.conan2/p/b/libcob7eabca8441d5/p/include/coro/net/tls/context.hpp
-- Installing: /home/conan/.conan2/p/b/libcob7eabca8441d5/p/include/coro/net/tls/connection_status.hpp
-- Installing: /home/conan/.conan2/p/b/libcob7eabca8441d5/p/include/coro/net/tls/server.hpp
-- Installing: /home/conan/.conan2/p/b/libcob7eabca8441d5/p/include/coro/net/tls/send_status.hpp
-- Installing: /home/conan/.conan2/p/b/libcob7eabca8441d5/p/include/coro/net/send_status.hpp
-- Installing: /home/conan/.conan2/p/b/libcob7eabca8441d5/p/include/coro/poll.hpp
-- Installing: /home/conan/.conan2/p/b/libcob7eabca8441d5/p/include/coro/time.hpp
-- Installing: /home/conan/.conan2/p/b/libcob7eabca8441d5/p/include/coro/when_all.hpp
-- Installing: /home/conan/.conan2/p/b/libcob7eabca8441d5/p/include/coro/task.hpp
-- Up-to-date: /home/conan/.conan2/p/b/libcob7eabca8441d5/p/include/coro
-- Installing: /home/conan/.conan2/p/b/libcob7eabca8441d5/p/include/coro/export.hpp
-- Installing: /home/conan/.conan2/p/b/libcob7eabca8441d5/p/lib/pkgconfig/libcoro.pc

libcoro/0.11: package(): Packaged 1 file: LICENSE
libcoro/0.11: package(): Packaged 1 '.a' file: libcoro.a
libcoro/0.11: package(): Packaged 44 '.hpp' files
libcoro/0.11: Created package revision 923f34f5ac1e5686b8eb9d72c72bc0bb
libcoro/0.11: Package '1e8144e18dbd4a4c38f943470166650dae9e25b1' created
libcoro/0.11: Full package reference: libcoro/0.11#c8785ea7de8cb6eb0c525b109ebde276:1e8144e18dbd4a4c38f943470166650dae9e25b1#923f34f5ac1e5686b8eb9d72c72bc0bb
libcoro/0.11: Package folder /home/conan/.conan2/p/b/libcob7eabca8441d5/p
WARN: deprecated: Usage of deprecated Conan 1.X features that will be removed in Conan 2.X:
WARN: deprecated:     'cpp_info.names' used in: tl-expected/1.1.0, c-ares/1.25.0, zlib/1.3.1, openssl/3.2.1
WARN: deprecated:     'env_info' used in: c-ares/1.25.0, openssl/3.2.1
WARN: deprecated:     'cpp_info.filenames' used in: tl-expected/1.1.0
WARN: deprecated:     'cpp_info.build_modules' used in: openssl/3.2.1

======== Launching test_package ========

======== Computing dependency graph ========
Graph root
    libcoro/0.11 (test package): /home/conan/project/all/test_package/conanfile.py
Requirements
    c-ares/1.25.0#b55eb90f63e256cfd7272b912b681258 - Cache
    libcoro/0.11#c8785ea7de8cb6eb0c525b109ebde276 - Cache
    openssl/3.2.1#39bd48ed31f1f3fbdcd75a0648aaedcf - Cache
    tl-expected/1.1.0#beaea6a1c8d4e2ec7985524fbe8967fd - Cache
    zlib/1.3.1#af8f2ef3d8e0fddf1975281d7fe43bf6 - Cache

======== Computing necessary packages ========
Requirements
    c-ares/1.25.0#b55eb90f63e256cfd7272b912b681258:2835c450acc09f3f265ad1a0c30b019fa2b06585#f545b3a32b170f19c26bd88b2d7e1619 - Cache
    libcoro/0.11#c8785ea7de8cb6eb0c525b109ebde276:1e8144e18dbd4a4c38f943470166650dae9e25b1#923f34f5ac1e5686b8eb9d72c72bc0bb - Cache
    openssl/3.2.1#39bd48ed31f1f3fbdcd75a0648aaedcf:7f4ff40bbfc1a5f62f937c537336b6e3297317c4#c2cf584bb569607060d35552250ec5a5 - Cache
    tl-expected/1.1.0#beaea6a1c8d4e2ec7985524fbe8967fd:da39a3ee5e6b4b0d3255bfef95601890afd80709#8009cbea1e813f9f9258a2f49dc12c81 - Cache
    zlib/1.3.1#af8f2ef3d8e0fddf1975281d7fe43bf6:659f5046bee3c5a8463ca82f0ce7aaba50748d87#795601090c402b6f0eb88c524400d24d - Cache

======== Installing packages ========
c-ares/1.25.0: Already installed! (1 of 5)
tl-expected/1.1.0: Already installed! (2 of 5)
zlib/1.3.1: Already installed! (3 of 5)
openssl/3.2.1: Already installed! (4 of 5)
libcoro/0.11: Already installed! (5 of 5)
WARN: deprecated: Usage of deprecated Conan 1.X features that will be removed in Conan 2.X:
WARN: deprecated:     'cpp_info.names' used in: tl-expected/1.1.0, c-ares/1.25.0, zlib/1.3.1, openssl/3.2.1
WARN: deprecated:     'env_info' used in: c-ares/1.25.0, openssl/3.2.1
WARN: deprecated:     'cpp_info.filenames' used in: tl-expected/1.1.0
WARN: deprecated:     'cpp_info.build_modules' used in: openssl/3.2.1

======== Testing the package ========
Removing previously existing 'test_package' build folder: /home/conan/project/all/test_package/build/gcc-11-x86_64-20-debug
libcoro/0.11 (test package): Test package build: build/gcc-11-x86_64-20-debug
libcoro/0.11 (test package): Test package build folder: /home/conan/project/all/test_package/build/gcc-11-x86_64-20-debug
libcoro/0.11 (test package): Writing generators to /home/conan/project/all/test_package/build/gcc-11-x86_64-20-debug/generators
libcoro/0.11 (test package): Generator 'CMakeToolchain' calling 'generate()'
libcoro/0.11 (test package): CMakeToolchain generated: conan_toolchain.cmake
libcoro/0.11 (test package): CMakeToolchain generated: CMakePresets.json
libcoro/0.11 (test package): CMakeToolchain generated: ../../../CMakeUserPresets.json
libcoro/0.11 (test package): Generator 'CMakeDeps' calling 'generate()'
libcoro/0.11 (test package): Generator 'VirtualRunEnv' calling 'generate()'
libcoro/0.11 (test package): Generating aggregated env files
libcoro/0.11 (test package): Generated aggregated env files: ['conanrun.sh', 'conanbuild.sh']

======== Testing the package: Building ========
libcoro/0.11 (test package): Calling build()
libcoro/0.11 (test package): Running CMake.configure()
libcoro/0.11 (test package): RUN: cmake -G "Unix Makefiles" -DCMAKE_TOOLCHAIN_FILE="/home/conan/project/all/test_package/build/gcc-11-x86_64-20-debug/generators/conan_toolchain.cmake" -DCMAKE_INSTALL_PREFIX="/home/conan/project/all/test_package" -DCMAKE_POLICY_DEFAULT_CMP0091="NEW" -DCMAKE_BUILD_TYPE="Debug" "/home/conan/project/all/test_package"
-- Using Conan toolchain: /home/conan/project/all/test_package/build/gcc-11-x86_64-20-debug/generators/conan_toolchain.cmake
-- Conan toolchain: C++ Standard 20 with extensions OFF
-- The CXX compiler identification is GNU 11.1.0
-- Check for working CXX compiler: /usr/local/bin/c++
-- Check for working CXX compiler: /usr/local/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Conan: Target declared 'libcoro::libcoro'
-- Conan: Component target declared 'OpenSSL::Crypto'
-- Conan: Component target declared 'OpenSSL::SSL'
-- Conan: Target declared 'openssl::openssl'
-- Conan: Target declared 'ZLIB::ZLIB'
-- Conan: Including build module from '/home/conan/.conan2/p/b/opens86765aa91692a/p/lib/cmake/conan-official-openssl-variables.cmake'
-- Conan: Component target declared 'c-ares::cares'
-- Conan: Component target declared 'tl::expected'
-- Configuring done
-- Generating done
-- Build files have been written to: /home/conan/project/all/test_package/build/gcc-11-x86_64-20-debug

libcoro/0.11 (test package): Running CMake.build()
libcoro/0.11 (test package): RUN: cmake --build "/home/conan/project/all/test_package/build/gcc-11-x86_64-20-debug" -- -j10
Scanning dependencies of target test_package
[ 50%] Building CXX object CMakeFiles/test_package.dir/test_package.cpp.o
[100%] Linking CXX executable test_package
[100%] Built target test_package


======== Testing the package: Executing test ========
libcoro/0.11 (test package): Running test()
libcoro/0.11 (test package): RUN: ./test_package
1
1
2
3
5
8
13
21
34
55
89

uilianries · 2024-02-14T16:13:52Z

Thanks for reporting the bug, and sorry for the problem! The change seemed harmless but clearly it needs some more testing around it. I'm about to head out skiing for the day so I'll check back in later to make sure everything on v0.11.1 is working well.

@jbaldwin No problem at all! Thank you for your quick hotfix! Have a great exercise ⛷️ !

update minimal cmake version required

eda6f59

Signed-off-by: Uilian Ries <[email protected]>

jbaldwin mentioned this pull request Feb 14, 2024

Revert cmake PROJECT_IS_TOP_LEVEL #252

Merged

install latest cmake

369d157

Signed-off-by: Uilian Ries <[email protected]>

uilianries closed this Feb 14, 2024

uilianries mentioned this pull request Feb 14, 2024

libcoro: add version 0.11.1 conan-io/conan-center-index#22764

Merged

3 tasks

jbaldwin mentioned this pull request Feb 15, 2024

Build conan package in CI and push on release #258

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[hotfix] cmake_dependent_option requires CMake 3.25 #251

[hotfix] cmake_dependent_option requires CMake 3.25 #251

uilianries commented Feb 14, 2024

uilianries commented Feb 14, 2024

jbaldwin commented Feb 14, 2024

jbaldwin commented Feb 14, 2024

jbaldwin commented Feb 14, 2024

uilianries commented Feb 14, 2024

jbaldwin commented Feb 14, 2024

jbaldwin commented Feb 14, 2024

uilianries commented Feb 14, 2024

uilianries commented Feb 14, 2024

[hotfix] cmake_dependent_option requires CMake 3.25 #251

[hotfix] cmake_dependent_option requires CMake 3.25 #251

Conversation

uilianries commented Feb 14, 2024

uilianries commented Feb 14, 2024

jbaldwin commented Feb 14, 2024

jbaldwin commented Feb 14, 2024

jbaldwin commented Feb 14, 2024

uilianries commented Feb 14, 2024

jbaldwin commented Feb 14, 2024

jbaldwin commented Feb 14, 2024

uilianries commented Feb 14, 2024

uilianries commented Feb 14, 2024