move the wildfly-maven-plugin configuration to top level so it can …
#6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…be used by multiple goals
|
@jamezp Could you please help to check this PR when you have time? I have checked it locally and it works with |
jamezp
approved these changes
Oct 4, 2024
There was a problem hiding this comment.
This looks good to me. By having this outside an execution you allow goals which have the same configuration parameters to work the same. For example, dev, start, run, provision and package will all provision the same server with this configuration. In the previous configuration all goals except provision would provision a full WildFly server without the JBeret version override.
|
@jamezp Thanks for reviewing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…be used by multiple goals