GitHub app auth #21
GitHub app auth #21
Conversation
| target_url, | ||
| description: 'Deployed to Incrementals.', | ||
| context: 'continuous-integration/jenkins/incrementals' | ||
| name: 'Incrementals', |
There was a problem hiding this comment.
this also looks like a change. Your changing from a commit status to a check?
There was a problem hiding this comment.
Yup, so I can get multi modules giving all links, was horrid UX for jenkins core before and others you had to replace the first modules artifact id with the one you wanted in the URL, it never got the hpi / war
There was a problem hiding this comment.
I had filed an issue to this effect somewhere. Maybe only jenkins-infra/helpdesk#2426.
There was a problem hiding this comment.
There we go, https://issues.jenkins.io/browse/JENKINS-52116 (CC @oleg-nenashev).
| target_url, | ||
| description: 'Deployed to Incrementals.', | ||
| context: 'continuous-integration/jenkins/incrementals' | ||
| name: 'Incrementals', |
There was a problem hiding this comment.
I had filed an issue to this effect somewhere. Maybe only jenkins-infra/helpdesk#2426.
| conclusion: 'success', | ||
| details_url: entries[0].url, | ||
| output: { | ||
| title: 'Deployed to Incrementals', |
There was a problem hiding this comment.
I wonder if we should pick text that is more self-descriptive for people who do not already know what this means? Somehow indicating that this snapshot-ish build is available for download or consumption from Maven in draft PRs, linking to jenkins.io docs, etc.
| details_url: entries[0].url, | ||
| output: { | ||
| title: 'Deployed to Incrementals', | ||
| summary: entries.map(entry => `- [${entry.artifactId}](${entry.url})`).join('\n') |
There was a problem hiding this comment.
And a good follow-up would be to show
<dependency>
<groupId>org.jenkins-ci.plugins</groupId>
<artifactId>stuff</artifactId>
<version>1.2-rcdead1234beef</version>
</dependency>
|
FTR this is deployed but since the security release yesterday I haven't had a single pipeline build work, jenkins-infra/helpdesk#2733 |
(Need to update infra first before merging to have the secrets etc)
Tested in:
Fixes #3
Fixes #4
Fixes jenkins-infra/helpdesk#2426