Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixup: correct details markdown for dependency metadata #84

Merged
merged 3 commits into from
Feb 10, 2024

Conversation

lemeurherve
Copy link
Member

@lemeurherve lemeurherve commented Feb 10, 2024

This PR sets the text value of the check run, using <pre>, &#xA; (new line) and &#60; (<) to avoid markdown rendering issue from #83: https://github.com/jenkinsci/jenkins-infra-test-plugin/pull/114/checks?check_run_id=21437296074

Before:
image

After:

<pre>&#xA;&#60;dependency>&#xA;  &#60;groupId>${entries[0].groupId}&#60;/groupId>&#xA;  &#60;artifactId>${entries[0].artifactId}&#60;/artifactId>&#xA;  &#60;version>${entries[0].version}&#60;/version>&#xA;&#60;/dependency>&#xA;</pre>
<dependency>
  <groupId>${entries[0].groupId}</groupId>
  <artifactId>${entries[0].artifactId}</artifactId>
  <version>${entries[0].version}</version>
</dependency>

Fixup of:

Ref:

@lemeurherve lemeurherve added the bug Something isn't working label Feb 10, 2024
@lemeurherve lemeurherve requested a review from timja February 10, 2024 14:38
@lemeurherve lemeurherve marked this pull request as draft February 10, 2024 14:40
@lemeurherve lemeurherve marked this pull request as ready for review February 10, 2024 14:43
@lemeurherve lemeurherve mentioned this pull request Feb 10, 2024
@lemeurherve lemeurherve merged commit e86338d into main Feb 10, 2024
8 checks passed
@lemeurherve lemeurherve deleted the lemeurherve-patch-1 branch February 10, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants