URL encode directory names in "all files in zip" link

[tchaikov]

Previously, directory names containing special characters (e.g., "[" or "]") would cause HTTP 400 errors due to illegal path characters. Now properly percent-encoding the directory name in the URL to handle special characters.

See JENKINS-XXXXX.

Testing done

Proposed changelog entries

• human-readable text

Proposed upgrade guidelines

N/A

Submitter checklist

Preview Give feedback

1. The Jira issue, if it exists, is well-described.
2. The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
3. There is automated testing or an explanation as to why this change has no tests.
4. New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
5. New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
6. New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
7. For dependency updates, there are links to external changelogs and, if possible, full differentials.
8. For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

Preview Give feedback

1. There are at least two (2) approvals for the pull request and no outstanding requests for change.
2. Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
3. Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
4. Proper changelog labels are set so that the changelog can be generated automatically.
5. If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
6. If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

[welcome]

Yay, your first pull request towards Jenkins core was created successfully! Thank you so much!

A contributor will provide feedback soon. Meanwhile, you can join the chats and community forums to connect with other Jenkins users, developers, and maintainers.

[timja]

Do spaces in the directory names still work?

We had a similar issue in the junit plugin and rawEncode had to be used instead of urlEncode

jenkinsci/junit-plugin#660 (comment)

jenkinsci/junit-plugin#661

and finally:
jenkinsci/junit-plugin#668

[timja]

Could you please include how its been tested in the testing done, including the cases you've tried

[tchaikov]

Could you please include how its been tested in the testing done, including the cases you've tried

Hi Tim

Thank you very much for your detailed insights and review. I haven't had the chance to properly test the changes yet. I will set up a local environment to verify the behavior you've described.

Since I'm not very familiar with Jenkins development and its setup process, it may take me some time to complete the testing. I'll update this PR once I've had a chance to verify everything locally.