Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL encode directory names in "all files in zip" link #10084

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

URL encode directory names in "all files in zip" link #10084

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/src/main/resources/hudson/model/DirectoryBrowserSupport/dir.jelly
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ THE SOFTWARE.
<tr>
<td style="text-align:right;" colspan="3">
<div style="margin-top: 1em;">
<a class="jenkins-link--with-icon" href="${backPath}${pattern!=''?pattern+'/':''}*zip*/${dir.name}.zip">
<a class="jenkins-link--with-icon" href="${backPath}${pattern!=''?pattern+'/':''}*zip*/${h.urlEncode(dir.name)}.zip">
Copy link
Member

@timja timja Dec 20, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do spaces in the directory names still work?

We had a similar issue in the junit plugin and rawEncode had to be used instead of urlEncode

jenkinsci/junit-plugin#660 (comment)

jenkinsci/junit-plugin#661

and finally:
jenkinsci/junit-plugin#668

<l:icon src="symbol-download"/>
(${%all files in zip})
</a>
Expand Down
Loading