Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPM - Enabled flags for 'install' command during dependency tree build #207

Conversation

eranturgeman
Copy link
Contributor

@eranturgeman eranturgeman commented Oct 25, 2023

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

Install command that might run during building NPM dependency tree is now able to get user provided flags.
This change is relevant only in some contexts that allow passing user's demands for the install command (for example: if coming from Frogbot)

@eranturgeman eranturgeman added the improvement Automatically generated release notes label Oct 26, 2023
…-customizable-install-command-for-dep-tree-build
build/utils/npm.go Outdated Show resolved Hide resolved
build/utils/npm.go Outdated Show resolved Hide resolved
build/utils/npm.go Outdated Show resolved Hide resolved
build/utils/npm.go Show resolved Hide resolved
build/utils/npm.go Outdated Show resolved Hide resolved
@eranturgeman eranturgeman temporarily deployed to frogbot October 30, 2023 11:48 — with GitHub Actions Inactive
@eranturgeman eranturgeman changed the title Improved install command during dep-tree build in NPM NPM - Enabled flags for 'install' command during dependency tree build Oct 30, 2023
Copy link
Contributor

@eyalbe4 eyalbe4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Let's just improve the inline comments grammar befire mergint the PR.

Copy link


@eranturgeman eranturgeman merged commit 13f94ab into jfrog:dev Oct 31, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Automatically generated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants