try with closed resources

jfrog · Sep 12, 2024 · 9ec102a · 9ec102a
1 parent cea9c45
commit 9ec102a
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/src/main/java/io/jenkins/plugins/jfrog/JfStep.java b/src/main/java/io/jenkins/plugins/jfrog/JfStep.java
@@ -216,7 +216,7 @@ private void configAllServers(Launcher.ProcStarter launcher, Job<?, ?> job) thro
         }
     }
 
-    private void addConfigArguments(ArgumentListBuilder builder, JFrogPlatformInstance jfrogPlatformInstance, String jfrogBinaryPath, Job<?, ?> job, Launcher.ProcStarter launcher) {
+    private void addConfigArguments(ArgumentListBuilder builder, JFrogPlatformInstance jfrogPlatformInstance, String jfrogBinaryPath, Job<?, ?> job, Launcher.ProcStarter launcher) throws IOException {
         String credentialsId = jfrogPlatformInstance.getCredentialsConfig().getCredentialsId();
         builder.add(jfrogBinaryPath).add("c").add("add").add(jfrogPlatformInstance.getId());
         // Add credentials
@@ -230,8 +230,9 @@ private void addConfigArguments(ArgumentListBuilder builder, JFrogPlatformInstan
             // Use password-stdin if available
             if (this.currentCliVersion.isAtLeast(MIN_CLI_VERSION_PASSWORD_STDIN)) {
                 builder.add("--password-stdin");
-                ByteArrayInputStream inputStream = new ByteArrayInputStream(credentials.getPassword().getPlainText().getBytes(StandardCharsets.UTF_8));
-                launcher.stdin(inputStream);
+                try(ByteArrayInputStream inputStream = new ByteArrayInputStream(credentials.getPassword().getPlainText().getBytes(StandardCharsets.UTF_8))) {
+                    launcher.stdin(inputStream);
+                }
             } else {
                 builder.addMasked("--password=" + credentials.getPassword());
             }