Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: free pydantic version #6150

Merged
merged 44 commits into from
Mar 24, 2025
Merged

chore: free pydantic version #6150

merged 44 commits into from
Mar 24, 2025

Conversation

JoanFM
Copy link
Member

@JoanFM JoanFM commented Mar 7, 2024

Goals:

  • resolves #ISSUE-NUMBER

  • ...

  • ...

  • ...

  • ...

  • check and update documentation. See guide and ask the team.

@github-actions github-actions bot added size/XS area/setup This issue/PR affects setting up Jina labels Mar 7, 2024
This was linked to issues Mar 7, 2024
Support docarray pydantic v2 #6086
Closed
Will the Pydantic dependency be upgraded in the future?Currently, due to version issues, some third-party packages are incompatible. #6125
Closed
@codecov Codecov
Copy link

codecov bot commented Mar 7, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 7.45342% with 149 lines in your changes missing coverage. Please review.

Project coverage is 43.77%. Comparing base (fa7f11b) to head (e2a4edd).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
jina/serve/runtimes/worker/http_csp_app.py 0.00% 63 Missing ⚠️
jina/_docarray_legacy.py 0.00% 19 Missing ⚠️
jina/serve/executors/__init__.py 6.66% 14 Missing ⚠️
...ina/serve/runtimes/gateway/graph/topology_graph.py 9.09% 10 Missing ⚠️
...ve/runtimes/gateway/http_fastapi_app_docarrayv2.py 0.00% 10 Missing ⚠️
jina/serve/runtimes/worker/request_handling.py 16.66% 10 Missing ⚠️
jina/serve/runtimes/worker/http_fastapi_app.py 0.00% 9 Missing ⚠️
jina/serve/runtimes/head/request_handling.py 0.00% 8 Missing ⚠️
jina/clients/mixin.py 40.00% 3 Missing ⚠️
jina/clients/base/http.py 50.00% 2 Missing ⚠️
... and 1 more
Additional details and impacted files 
@@             Coverage Diff             @@
##           master    #6150       +/-   ##
===========================================
- Coverage   54.32%   43.77%   -10.56%     
===========================================
  Files         150      151        +1     
  Lines       14255    14335       +80     
===========================================
- Hits         7744     6275     -1469     
- Misses       6511     8060     +1549
Flag Coverage Δ
jina 43.77% <7.45%> (-10.56%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions github-actions bot added size/S area/core This issue/PR affects the core codebase area/helper This issue/PR affects the helper functionality labels Mar 7, 2024
@JoanFM JoanFM force-pushed the chore-free-Pydantic-version branch from 62f6c98 to ecdf2b6 Compare March 7, 2024 09:13
@github-actions github-actions bot added size/M area/testing This issue/PR affects testing labels Mar 7, 2024
@TamiasSibiricus TamiasSibiricus mentioned this pull request Apr 25, 2024
Closed
@github-actions github-actions bot added size/L area/cicd This issue/PR affects the cicd pipeline area/housekeeping This issue/PR is housekeeping component/client labels Mar 18, 2025
@github-actions GitHub Actions
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions GitHub Actions
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions GitHub Actions
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions GitHub Actions
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@JoanFM JoanFM closed this Mar 21, 2025
@JoanFM JoanFM reopened this Mar 21, 2025
@github-actions GitHub Actions
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions GitHub Actions
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions GitHub Actions
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

1 similar comment
@github-actions GitHub Actions
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@JoanFM JoanFM force-pushed the chore-free-Pydantic-version branch from dfa52b9 to 0c33396 Compare March 21, 2025 12:37
@github-actions GitHub Actions
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@JoanFM JoanFM force-pushed the chore-free-Pydantic-version branch from 0c33396 to 155e919 Compare March 21, 2025 12:43
@github-actions GitHub Actions
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

1 similar comment
@github-actions GitHub Actions
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@JoanFM JoanFM force-pushed the chore-free-Pydantic-version branch from e2a4edd to f69315f Compare March 24, 2025 13:22
@github-actions GitHub Actions
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@JoanFM JoanFM marked this pull request as ready for review March 24, 2025 13:38
@JoanFM JoanFM requested review from hanxiao and nan-wang as code owners March 24, 2025 13:38
@JoanFM JoanFM merged commit ff36738 into master Mar 24, 2025
128 checks passed
@JoanFM JoanFM deleted the chore-free-Pydantic-version branch March 24, 2025 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanxiao hanxiao Awaiting requested review from hanxiao hanxiao is a code owner

@nan-wang nan-wang Awaiting requested review from nan-wang nan-wang is a code owner

Assignees
No one assigned
Labels
area/cicd This issue/PR affects the cicd pipeline area/core This issue/PR affects the core codebase area/docker This issue/PR affects the docker functionality area/helper This issue/PR affects the helper functionality area/housekeeping This issue/PR is housekeeping area/setup This issue/PR affects setting up Jina area/testing This issue/PR affects testing component/client size/L size/M size/S size/XL size/XS
Projects
None yet
Milestone
No milestone
2 participants
@JoanFM @jina-bot