Refactor tests, splitting out Consolonia.NUnit library and a ton of unit tests #251
Annotations
1 error, 12 warnings, and 10 notices
build
Issues found.
|
build
The following actions uses node12 which is deprecated and will be forced to run on node16: xt0rted/pull-request-comment-branch@v1, actions/checkout@v2, actions/setup-dotnet@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
build
The following actions use a deprecated Node.js version and will be forced to run on node20: xt0rted/pull-request-comment-branch@v1, actions/checkout@v2, actions/setup-dotnet@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
build:
src/Consolonia.Core/Helpers/Extensions.cs#L39
"[CSharpWarnings::CS1573] Parameter 'supportsComplexEmoji' has no matching param tag in the XML comment for Consolonia.Core.Helpers.Extensions.GetGlyphs (but other parameters do)" on /home/runner/work/Consolonia/Consolonia/src/Consolonia.Core/Helpers/Extensions.cs(39,78)
|
build:
src/Tests/Consolonia.Core.Tests/DrawingBoxSymbolTests.cs#L2
"[RedundantUsingDirective] Using directive is not required by the code and can be safely removed" on /home/runner/work/Consolonia/Consolonia/src/Tests/Consolonia.Core.Tests/DrawingBoxSymbolTests.cs(2,1)
|
build:
src/Tests/Consolonia.Core.Tests/GlyphTests.cs#L1
"[RedundantUsingDirective] Using directive is not required by the code and can be safely removed" on /home/runner/work/Consolonia/Consolonia/src/Tests/Consolonia.Core.Tests/GlyphTests.cs(1,1)
|
build:
src/Tests/Consolonia.Core.Tests/GlyphTests.cs#L2
"[RedundantUsingDirective] Using directive is not required by the code and can be safely removed" on /home/runner/work/Consolonia/Consolonia/src/Tests/Consolonia.Core.Tests/GlyphTests.cs(2,1)
|
build:
src/Tests/Consolonia.Core.Tests/GlyphTests.cs#L4
"[RedundantUsingDirective] Using directive is not required by the code and can be safely removed" on /home/runner/work/Consolonia/Consolonia/src/Tests/Consolonia.Core.Tests/GlyphTests.cs(4,1)
|
build:
src/Tests/Consolonia.Core.Tests/PixelForegroundTests.cs#L2
"[RedundantUsingDirective] Using directive is not required by the code and can be safely removed" on /home/runner/work/Consolonia/Consolonia/src/Tests/Consolonia.Core.Tests/PixelForegroundTests.cs(2,1)
|
build:
src/Tests/Consolonia.Core.Tests/PixelTests.cs#L3
"[RedundantUsingDirective] Using directive is not required by the code and can be safely removed" on /home/runner/work/Consolonia/Consolonia/src/Tests/Consolonia.Core.Tests/PixelTests.cs(3,1)
|
build:
src/Tests/Consolonia.Core.Tests/SimpleSymbolTests.cs#L3
"[RedundantUsingDirective] Using directive is not required by the code and can be safely removed" on /home/runner/work/Consolonia/Consolonia/src/Tests/Consolonia.Core.Tests/SimpleSymbolTests.cs(3,1)
|
build:
src/Tests/Consolonia.Core.Tests/SimpleSymbolTests.cs#L4
"[RedundantUsingDirective] Using directive is not required by the code and can be safely removed" on /home/runner/work/Consolonia/Consolonia/src/Tests/Consolonia.Core.Tests/SimpleSymbolTests.cs(4,1)
|
build:
src/Tests/Consolonia.Core.Tests/SimpleSymbolTests.cs#L6
"[RedundantUsingDirective] Using directive is not required by the code and can be safely removed" on /home/runner/work/Consolonia/Consolonia/src/Tests/Consolonia.Core.Tests/SimpleSymbolTests.cs(6,1)
|
build:
src/Consolonia.Core/Drawing/DrawingContextImpl.cs#L98
"[ArgumentsStyleNamedExpression] Inconsistent argument style: redundant name identifier" on /home/runner/work/Consolonia/Consolonia/src/Consolonia.Core/Drawing/DrawingContextImpl.cs(98,70)
|
build:
src/Consolonia.NUnit/UnitTestConsole.cs#L69
"[ArgumentsStyleNamedExpression] Inconsistent argument style: redundant name identifier" on /home/runner/work/Consolonia/Consolonia/src/Consolonia.NUnit/UnitTestConsole.cs(69,69)
|
build:
src/Tests/Consolonia.Core.Tests/PixelTests.cs#L49
"[ArgumentsStyleNamedExpression] Inconsistent argument style: redundant name identifier" on /home/runner/work/Consolonia/Consolonia/src/Tests/Consolonia.Core.Tests/PixelTests.cs(49,92)
|
build:
src/Consolonia.Core/Drawing/ConsoleBrush.cs#L188
"[ConvertIfStatementToSwitchStatement] Convert 'if' statement into 'switch' statement" on /home/runner/work/Consolonia/Consolonia/src/Consolonia.Core/Drawing/ConsoleBrush.cs(188,13)
|
build:
src/Consolonia.Core/Drawing/BitmapImpl.cs#L63
"[ConvertToConstant.Local] Convert into constant" on /home/runner/work/Consolonia/Consolonia/src/Consolonia.Core/Drawing/BitmapImpl.cs(63,17)
|
build:
src/Tests/Consolonia.Core.Tests/GlyphTests.cs#L23
"[ConvertToConstant.Local] Convert into constant" on /home/runner/work/Consolonia/Consolonia/src/Tests/Consolonia.Core.Tests/GlyphTests.cs(23,17)
|
build:
src/Tests/Consolonia.Core.Tests/GlyphTests.cs#L34
"[ConvertToConstant.Local] Convert into constant" on /home/runner/work/Consolonia/Consolonia/src/Tests/Consolonia.Core.Tests/GlyphTests.cs(34,17)
|
build:
src/Tests/Consolonia.Core.Tests/GlyphTests.cs#L49
"[ConvertToConstant.Local] Convert into constant" on /home/runner/work/Consolonia/Consolonia/src/Tests/Consolonia.Core.Tests/GlyphTests.cs(49,17)
|
build:
src/Tests/Consolonia.Core.Tests/GlyphTests.cs#L64
"[ConvertToConstant.Local] Convert into constant" on /home/runner/work/Consolonia/Consolonia/src/Tests/Consolonia.Core.Tests/GlyphTests.cs(64,17)
|
build:
src/Tests/Consolonia.Core.Tests/GlyphTests.cs#L75
"[ConvertToConstant.Local] Convert into constant" on /home/runner/work/Consolonia/Consolonia/src/Tests/Consolonia.Core.Tests/GlyphTests.cs(75,17)
|