Refactor tests, splitting out Consolonia.NUnit library and a ton of unit tests #259
tomlmAnnotations
1 error, 12 warnings, and 10 notices
|
build
Issues found.
|
|
build
The following actions uses node12 which is deprecated and will be forced to run on node16: xt0rted/pull-request-comment-branch@v1, actions/checkout@v2, actions/setup-dotnet@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
build
The following actions use a deprecated Node.js version and will be forced to run on node20: xt0rted/pull-request-comment-branch@v1, actions/checkout@v2, actions/setup-dotnet@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
build:
src/Tests/Consolonia.Core.Tests/PixelForegroundTests.cs#L78
"[RedundantArgumentDefaultValue] The parameter 'style' has the same default value" on /home/runner/work/Consolonia/Consolonia/src/Tests/Consolonia.Core.Tests/PixelForegroundTests.cs(78,110)
|
|
build:
src/Tests/Consolonia.Core.Tests/PixelForegroundTests.cs#L90
"[RedundantArgumentDefaultValue] The parameter 'style' has the same default value" on /home/runner/work/Consolonia/Consolonia/src/Tests/Consolonia.Core.Tests/PixelForegroundTests.cs(90,99)
|
|
build:
src/Tests/Consolonia.Core.Tests/PixelForegroundTests.cs#L91
"[RedundantArgumentDefaultValue] The parameter 'style' has the same default value" on /home/runner/work/Consolonia/Consolonia/src/Tests/Consolonia.Core.Tests/PixelForegroundTests.cs(91,100)
|
|
build:
src/Tests/Consolonia.Core.Tests/PixelForegroundTests.cs#L92
"[RedundantArgumentDefaultValue] The parameter 'style' has the same default value" on /home/runner/work/Consolonia/Consolonia/src/Tests/Consolonia.Core.Tests/PixelForegroundTests.cs(92,97)
|
|
build:
src/Tests/Consolonia.Core.Tests/PixelForegroundTests.cs#L78
"[RedundantArgumentDefaultValue] The parameter 'textDecorations' has the same default value" on /home/runner/work/Consolonia/Consolonia/src/Tests/Consolonia.Core.Tests/PixelForegroundTests.cs(78,128)
|
|
build:
src/Tests/Consolonia.Core.Tests/PixelForegroundTests.cs#L90
"[RedundantArgumentDefaultValue] The parameter 'textDecorations' has the same default value" on /home/runner/work/Consolonia/Consolonia/src/Tests/Consolonia.Core.Tests/PixelForegroundTests.cs(90,117)
|
|
build:
src/Tests/Consolonia.Core.Tests/PixelForegroundTests.cs#L91
"[RedundantArgumentDefaultValue] The parameter 'textDecorations' has the same default value" on /home/runner/work/Consolonia/Consolonia/src/Tests/Consolonia.Core.Tests/PixelForegroundTests.cs(91,118)
|
|
build:
src/Tests/Consolonia.Core.Tests/PixelForegroundTests.cs#L92
"[RedundantArgumentDefaultValue] The parameter 'textDecorations' has the same default value" on /home/runner/work/Consolonia/Consolonia/src/Tests/Consolonia.Core.Tests/PixelForegroundTests.cs(92,115)
|
|
build:
src/Tests/Consolonia.Core.Tests/PixelForegroundTests.cs#L93
"[RedundantArgumentDefaultValue] The parameter 'textDecorations' has the same default value" on /home/runner/work/Consolonia/Consolonia/src/Tests/Consolonia.Core.Tests/PixelForegroundTests.cs(93,117)
|
|
build:
src/Tests/Consolonia.Core.Tests/PixelForegroundTests.cs#L78
"[RedundantArgumentDefaultValue] The parameter 'weight' has the same default value" on /home/runner/work/Consolonia/Consolonia/src/Tests/Consolonia.Core.Tests/PixelForegroundTests.cs(78,91)
|
|
build:
src/Consolonia.Core/Drawing/PixelBufferImplementation/DrawingBoxSymbol.cs#L141
"[ArrangeThisQualifier] Qualifier 'this.' is redundant" on /home/runner/work/Consolonia/Consolonia/src/Consolonia.Core/Drawing/PixelBufferImplementation/DrawingBoxSymbol.cs(141,49)
|
|
build:
src/Consolonia.Core/Drawing/PixelBufferImplementation/Pixel.cs#L133
"[ArrangeThisQualifier] Qualifier 'this.' is redundant" on /home/runner/work/Consolonia/Consolonia/src/Consolonia.Core/Drawing/PixelBufferImplementation/Pixel.cs(133,38)
|
|
build:
src/Consolonia.Core/Drawing/PixelBufferImplementation/PixelBackground.cs#L53
"[ArrangeThisQualifier] Qualifier 'this.' is redundant" on /home/runner/work/Consolonia/Consolonia/src/Consolonia.Core/Drawing/PixelBufferImplementation/PixelBackground.cs(53,48)
|
|
build:
src/Consolonia.Core/Drawing/PixelBufferImplementation/PixelForeground.cs#L59
"[ArrangeThisQualifier] Qualifier 'this.' is redundant" on /home/runner/work/Consolonia/Consolonia/src/Consolonia.Core/Drawing/PixelBufferImplementation/PixelForeground.cs(59,48)
|
|
build:
src/Consolonia.Core/Drawing/PixelBufferImplementation/SimpleSymbol.cs#L54
"[ArrangeThisQualifier] Qualifier 'this.' is redundant" on /home/runner/work/Consolonia/Consolonia/src/Consolonia.Core/Drawing/PixelBufferImplementation/SimpleSymbol.cs(54,45)
|
|
build:
src/Tests/Consolonia.Core.Tests/PixelForegroundTests.cs#L94
"[ArrangeTrailingCommaInMultilineLists] Remove trailing comma to conform to code style" on /home/runner/work/Consolonia/Consolonia/src/Tests/Consolonia.Core.Tests/PixelForegroundTests.cs(94,143)
|
|
build:
src/Consolonia.Core/Drawing/ConsoleBrush.cs#L188
"[ConvertIfStatementToSwitchStatement] Convert 'if' statement into 'switch' statement" on /home/runner/work/Consolonia/Consolonia/src/Consolonia.Core/Drawing/ConsoleBrush.cs(188,13)
|
|
build:
src/Consolonia.Core/Drawing/BitmapImpl.cs#L63
"[ConvertToConstant.Local] Convert into constant" on /home/runner/work/Consolonia/Consolonia/src/Consolonia.Core/Drawing/BitmapImpl.cs(63,17)
|
|
build:
src/Tests/Consolonia.Core.Tests/GlyphTests.cs#L20
"[ConvertToConstant.Local] Convert into constant" on /home/runner/work/Consolonia/Consolonia/src/Tests/Consolonia.Core.Tests/GlyphTests.cs(20,20)
|
|
build:
src/Tests/Consolonia.Core.Tests/GlyphTests.cs#L31
"[ConvertToConstant.Local] Convert into constant" on /home/runner/work/Consolonia/Consolonia/src/Tests/Consolonia.Core.Tests/GlyphTests.cs(31,20)
|