Skip to content

Add ConsoloniaAccessText underline #550

Add ConsoloniaAccessText underline

Add ConsoloniaAccessText underline #550

Triggered via pull request December 14, 2024 02:20
Status Failure
Total duration 40s
Artifacts

general_build.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

9 errors and 1 warning
build: src/Consolonia.Core/Controls/ConsoloniaAccessText.cs#L14
The field 'ConsoloniaAccessText._disposed' is assigned but its value is never used
build: src/Consolonia.Core/Controls/ConsoloniaAccessText.cs#L12
Provide an overridable implementation of Dispose(bool) on 'ConsoloniaAccessText' or mark the type as sealed. A call to Dispose(false) should only clean up native resources. A call to Dispose(true) should clean up both managed and native resources. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063)
build: src/Consolonia.Core/Controls/ConsoloniaAccessText.cs#L22
Modify 'ConsoloniaAccessText.Dispose' so that it calls Dispose(true), then calls GC.SuppressFinalize on the current object instance ('this' or 'Me' in Visual Basic), and then returns (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063)
build: src/Consolonia.Core/Controls/ConsoloniaAccessText.cs#L22
Change ConsoloniaAccessText.Dispose() to call GC.SuppressFinalize(object). This will prevent derived types that introduce a finalizer from needing to re-implement 'IDisposable' to call it. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1816)
build: src/Consolonia.Core/Controls/ConsoloniaAccessText.cs#L14
The field 'ConsoloniaAccessText._disposed' is assigned but its value is never used
build: src/Consolonia.Core/Controls/ConsoloniaAccessText.cs#L12
Provide an overridable implementation of Dispose(bool) on 'ConsoloniaAccessText' or mark the type as sealed. A call to Dispose(false) should only clean up native resources. A call to Dispose(true) should clean up both managed and native resources. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063)
build: src/Consolonia.Core/Controls/ConsoloniaAccessText.cs#L22
Modify 'ConsoloniaAccessText.Dispose' so that it calls Dispose(true), then calls GC.SuppressFinalize on the current object instance ('this' or 'Me' in Visual Basic), and then returns (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063)
build: src/Consolonia.Core/Controls/ConsoloniaAccessText.cs#L22
Change ConsoloniaAccessText.Dispose() to call GC.SuppressFinalize(object). This will prevent derived types that introduce a finalizer from needing to re-implement 'IDisposable' to call it. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1816)
build
Process completed with exit code 1.
build
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636