lint fixes

src/Consolonia.Core/Drawing/ConsoleBrush.cs

@@ -1,6 +1,4 @@
 using System;
-using System.ComponentModel;
-using System.Globalization;
 using Avalonia;
 using Avalonia.Media;
 using Consolonia.Core.Drawing.PixelBufferImplementation;
@@ -183,6 +181,8 @@ private static Color InterpolateColor(IGradientBrush brush, double relativePosit
                     break;
                 }
             }
+            if (before == null && after == null)
+                throw new ArgumentException("no gradientstops defined");
 
             if (before == null)
             {

src/Consolonia.Core/Drawing/DrawingContextImpl.cs

@@ -126,8 +126,6 @@ public void DrawGeometry(IBrush brush, IPen pen, IGeometryImpl geometry)
                             }
                             return;
                         }
-                    default:
-                        break;
                 }
 
                 Rect r2 = r.TransformToAABB(Transform);
@@ -270,7 +268,7 @@ public Matrix Transform
             lineStyle = null;
             if (pen is not
                 {
-                    Brush: ConsoleBrush or LineBrush or ImmutablePen or ImmutableSolidColorBrush,
+                    Brush: ConsoleBrush or LineBrush or ImmutableSolidColorBrush,
                     Thickness: 1,
                     DashStyle: null or { Dashes: { Count: 0 } },
                     LineCap: PenLineCap.Flat,

src/Consolonia.Core/Drawing/PixelBufferImplementation/Pixel.cs

@@ -1,8 +1,5 @@
 using System;
-using System.Diagnostics.CodeAnalysis;
-using Avalonia.Controls.Documents;
 using Avalonia.Media;
-using Consolonia.Core.Text;
 
 // ReSharper disable MemberCanBePrivate.Global
 // ReSharper disable UnusedMember.Global
@@ -28,7 +25,7 @@ public Pixel(char character, Color foregroundColor, FontStyle style = FontStyle.
         }
 
         public Pixel(byte drawingBoxSymbol, Color foregroundColor) : this(
-            new DrawingBoxSymbol(drawingBoxSymbol), foregroundColor, FontStyle.Normal, FontWeight.Normal)
+            new DrawingBoxSymbol(drawingBoxSymbol), foregroundColor)
         {
         }
 
@@ -71,12 +68,13 @@ public Pixel Blend(Pixel pixelAbove)
                 case PixelBackgroundMode.Transparent:
                     // when a textdecoration of underline happens a DrawLine() is called over the top of the a pixel with non-zero symbol.
                     // this detects this situation and eats the draw line, turning it into a textdecoration
-                    if (pixelAbove.Foreground.Symbol is DrawingBoxSymbol box &&
+                    if (pixelAbove.Foreground.Symbol is DrawingBoxSymbol &&
                         this.Foreground.Symbol is SimpleSymbol simpleSymbol &&
                         ((ISymbol)simpleSymbol).GetCharacter() != (Char)0)
+
                     {
                         // this is a line being draw through text. add TextDecoration for underline.
-                        newForeground = new PixelForeground(this.Foreground.Symbol, this.Foreground.Weight, this.Foreground.Style, TextDecorations.Underline,  this.Foreground.Color);
+                        newForeground = new PixelForeground(Foreground.Symbol, Foreground.Weight, Foreground.Style, TextDecorations.Underline, Foreground.Color);
                     }
                     else
                     {

src/Consolonia.Core/Drawing/PixelBufferImplementation/PixelBackground.cs

@@ -1,5 +1,4 @@
 using System;
-using System.Diagnostics.CodeAnalysis;
 using Avalonia.Media;
 
 namespace Consolonia.Core.Drawing.PixelBufferImplementation

src/Consolonia.Core/Drawing/PixelBufferImplementation/PixelForeground.cs

@@ -9,7 +9,7 @@ public readonly struct PixelForeground
         public PixelForeground(ISymbol symbol, FontWeight weight = FontWeight.Normal, FontStyle style = FontStyle.Normal, TextDecorationCollection textDecorations = null, Color? color = null)
         {
             ArgumentNullException.ThrowIfNull(symbol);
-            Symbol = symbol ?? new SimpleSymbol('░');
+            Symbol = symbol;
             Color = color ?? Colors.White;
             Weight = weight;
             Style = style;

src/Consolonia.Core/Drawing/PixelBufferImplementation/SimpleSymbol.cs

@@ -1,5 +1,3 @@
-using System;
-
 namespace Consolonia.Core.Drawing.PixelBufferImplementation
 {
     public readonly struct SimpleSymbol : ISymbol

src/Consolonia.Core/Drawing/RenderTarget.cs

@@ -6,7 +6,6 @@
 using Avalonia;
 using Avalonia.Controls;
 using Avalonia.Media;
-using Avalonia.Media.TextFormatting.Unicode;
 using Avalonia.Platform;
 using Consolonia.Core.Drawing.PixelBufferImplementation;
 using Consolonia.Core.Infrastructure;
@@ -117,8 +116,7 @@ private void RenderToDevice()
                  if (!_consoleWindow.InvalidatedRects.Any(rect =>
                     rect.ContainsExclusive(new Point(x, y)))) continue;*/
                 if (pixel.Background.Mode != PixelBackgroundMode.Colored)
-                    throw new InvalidOperationException(
-                        "All pixels in the buffer must have exact console color before rendering");
+                    throw new InvalidOperationException("All pixels in the buffer must have exact console color before rendering");
 
                     if (x == pixelBuffer.Width - 1 && y == pixelBuffer.Height - 1)
                         break;

src/Consolonia.Core/Infrastructure/InputLessDefaultNetConsole.cs

@@ -1,5 +1,4 @@
 using System;
-using System.Diagnostics;
 using System.Linq;
 using System.Text;
 using System.Threading.Tasks;

src/Consolonia.Core/Text/GlyphRunImpl.cs

@@ -1,4 +1,3 @@
-using System;
 using System.Collections.Generic;
 using System.Linq;
 using Avalonia;

src/Consolonia.Core/Text/TextShaper.cs

@@ -14,7 +14,7 @@ public ShapedBuffer ShapeText(ReadOnlyMemory<char> text, TextShaperOptions optio
             var glyphInfos = Convert(text.Span.ToString());
 
             var shapedBuffer = new ShapedBuffer(text, glyphInfos.Length,
-                options.Typeface ?? new GlyphTypeface(), 1, 0 /*todo: must be 1 for right to left?*/);
+                options.Typeface, 1, 0 /*todo: must be 1 for right to left?*/);
 
             for (int i = 0; i < shapedBuffer.Length; i++) shapedBuffer[i] = glyphInfos[i];
             return shapedBuffer;