avoid linq for creating glyph and advances array fix test names

jinek · Nov 10, 2024 · cbb342e · cbb342e
1 parent 14ae365
commit cbb342e
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 8 deletions.
diff --git a/src/Consolonia.Core/Text/GlyphTypeface.cs b/src/Consolonia.Core/Text/GlyphTypeface.cs
@@ -1,5 +1,4 @@
 using System;
-using System.Linq;
 using Avalonia.Media;
 using Consolonia.Core.Drawing;
 
@@ -41,7 +40,9 @@ public bool TryGetGlyph(uint codepoint, out ushort glyph)
 
         public ushort[] GetGlyphs(ReadOnlySpan<uint> codepoints)
         {
-            return Enumerable.Repeat(Glyph, codepoints.Length).ToArray();
+            ushort[] glyphs = new ushort[codepoints.Length];
+            Array.Fill(glyphs, Glyph);
+            return glyphs;
         }
 
         public int GetGlyphAdvance(ushort glyph)
@@ -51,7 +52,9 @@ public int GetGlyphAdvance(ushort glyph)
 
         public int[] GetGlyphAdvances(ReadOnlySpan<ushort> glyphs)
         {
-            return Enumerable.Repeat(1, glyphs.Length).ToArray();
+            int[] advances = new int[glyphs.Length];
+            Array.Fill(advances, 1);
+            return advances;
         }
 
         public bool TryGetTable(uint tag, out byte[] table)

diff --git a/src/Tests/Consolonia.Gallery.Tests/TextBlockTests.cs b/src/Tests/Consolonia.Gallery.Tests/TextBlockTests.cs
@@ -13,14 +13,14 @@ namespace Consolonia.Gallery.Tests
     internal class TextBlockTests : GalleryTestsBaseBase
     {
         [Test]
-        public async Task TextBlock_DisplaysBasicText()
+        public async Task DisplaysBasicText()
         {
             await UITest.KeyInput(Key.Tab);
             await UITest.AssertHasText("This is TextBlock");
         }
 
         [Test]
-        public async Task TextBlock_HandlesTrimming()
+        public async Task HandlesTrimming()
         {
             await UITest.KeyInput(Key.Tab);
             await UITest.AssertHasText(
@@ -29,7 +29,7 @@ await UITest.AssertHasText(
         }
 
         [Test]
-        public async Task TextBlock_HandlesAlignment()
+        public async Task HandlesAlignment()
         {
             await UITest.KeyInput(Key.Tab);
             await UITest.AssertHasText(
@@ -39,7 +39,7 @@ await UITest.AssertHasText(
         }
 
         [Test]
-        public async Task TextBlock_HandlesMultilineText()
+        public async Task HandlesMultilineText()
         {
             await UITest.KeyInput(Key.Tab);
             await UITest.AssertHasText(
@@ -48,7 +48,7 @@ await UITest.AssertHasText(
         }
 
         [Test]
-        public async Task TextBlock_HandlesSpecialCharacters()
+        public async Task HandlesSpecialCharacters()
         {
             await UITest.KeyInput(Key.Tab);
             await UITest.AssertHasText(