105 choredeps upgrade avalonia dependencies to 1100 #119

jinek · 2024-10-19T19:59:28Z

Overhauled various files through code refactoring, removing unnecessary attributes, updating type definitions, cleaning up method signatures. Significant changes were made to the Core/Infrastructure platform and several TurboVision themes and templates.

This commit transitions helper methods to use a new syntax, and adjusts various bindings in grid items and data templates. In several instances, template-related properties such as design width and height were removed. Changes were also made to focus management, specifically transitioning from using the deprecated FocusManager.Instance to using AvaloniaLocator for service retrieval. The GlyphRun creation was refactored in SymbolsControl.cs.

Introduced Avalonia threading in ConsoloniaPlatform, and bound to a new ManagedDispatcherImpl. Moreover, text shaping has been improved in SymbolsControl by replacing the default measure with an enumerable list of GlyphInfo. Some code has been commented out in ApplicationStartup for later consideration.

Removed dependency on IPlatformRenderInterface in several methods of ConsoloniaRenderInterface and adjusted corresponding logic. Improved DrawGlyphRun method's implementation in DrawingContextImpl, modifying glyphRun checks and string drawing. Made small adjustments to classes MoveConsoleCaretToPositionBrush and FourBitColorBrush for better alignment with IImmutableBrush.

The transform in the DrawingContextImpl.cs was updated to be initialized with Matrix identity. Removed the unused methods related to geometry and rendering in ConsoloniaRenderInterface.cs. Made a small adjustment to exception message in RenderTarget.cs for clarity.

Co-authored-by: <[email protected]>

This reverts commit e9c3497.

tomlm · 2024-10-26T22:29:38Z

It would be good to have a drag and drop test in the gallery, as I think the events for click and move are not modeled correctly.

jinek · 2024-10-26T22:35:54Z

It would be good to have a drag and drop test in the gallery, as I think the events for click and move are not modeled correctly.

True.
But, I think this should be addressed in a separate task. In this PR, it is probably better just to upgrade to new Avalonia while avoiding regression. I'm assuming existing issues from the previous version may remain.

tomlm

I"m going to approve despite not really understanding the code, because it's important to get onto the avalonia 11 code base :)

tomlm · 2024-10-27T17:05:37Z

Hey, I have 2 bug fixes to this delta. Do you want me to just push to this PR or do a separate PR?
Fixed

click drag causes exception to throw
Scroll wheel takes 12 clicks to scroll listbox 1 notch.
Added Cursor viewer to gallery so you can inspect cursor events.

tomlm · 2024-10-29T01:07:45Z

Wow, ok. I was testing the wrong branch. I just tested with the avalonia based code 11 and it works MUCH better!

Nice job!
(BTW: my bug fixes still apply)

jinek · 2024-10-29T01:24:20Z

Hey, I have 2 bug fixes to this delta. Do you want me to just push to this PR or do a separate PR?
Fixed

click drag causes exception to throw

Scroll wheel takes 12 clicks to scroll listbox 1 notch.

Added Cursor viewer to gallery so you can inspect cursor events.

Great! I think better to do a separate one.

coderabbitai · 2024-10-29T12:29:48Z

Important

Review skipped

More than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review.

58 files out of 140 files are above the max files limit of 75. Please upgrade to Pro plan to get higher limits.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

Co-authored-by: <[email protected]>

jinek · 2024-10-29T19:58:42Z

Nice job! (BTW: my bug fixes still apply)

Thank you for help very much! We can now jump to your fixes/improvements.

jinek added 30 commits April 14, 2024 01:02

Avalonia 11.0.9

17d9623

more fixes

4dd755d

application is now being run, but does not render

6efaf75

Welcome page is rendered

b0cf503

Window is painted when resized

bb117b0

Clickable button

acfc4fd

- unused code

ed52281

- unused button

259893e

Button shadow drawing

dc51e56

Button drawing/ SymbolsControl.cs drawing

773b1e6

text trimming is fixed

2eff951

Wild text rendering

d69b033

Platform settings for investigation

7edf517

LineBrush is rendered

40e45ec

ScrollViewer now works

2a609ce

Null reference check brought back

52bf2fb

hit test for GlyphRun

9204d7f

+1, similar to avalonia

3a2579d

Textbox working

2b66acf

more textbox

d372108

keyboardnavigationhandler is back

d0d399f

combobox fix 1

48d031f

ComboBox drop-down works fine

f15265e

array in the combobox items

874b29d

Single test run. Buttons and TextBlock tests success separately.

478fd6a

jinek and others added 14 commits October 20, 2024 19:01

FlyoutTests.cs

77af91f

PR fixes

e845e75

build fixes

8efff9e

refactoring

121221a

formatting and small fixes

8962d2c

Limits to run jobs

d1cbe6b

newer analysis version and null referene fix

5f0bd23

Delegate error

36cfbcc

other errors

c1de176

PR fixes

1b0ab64

last warning

5a84e0f

Automated JetBrains cleanup

e9c3497

Co-authored-by: <[email protected]>

newer jb version

2dcb1c8

Revert "Automated JetBrains cleanup"

34c9336

This reverts commit e9c3497.

tomlm approved these changes Oct 27, 2024

View reviewed changes

tomlm approved these changes Oct 29, 2024

View reviewed changes

refactoring and formatting

cf992dd

jinek and others added 4 commits October 29, 2024 20:13

+ code inspection fixes

4dd039c

last warning

ce70e76

All notices fixed

46b6c62

Automated JetBrains cleanup

d4f7440

Co-authored-by: <[email protected]>

jinek merged commit 9264d99 into main Oct 29, 2024
2 checks passed

jinek deleted the 105-choredeps-upgrade-avalonia-dependencies-to-1100 branch October 29, 2024 19:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

105 choredeps upgrade avalonia dependencies to 1100 #119

105 choredeps upgrade avalonia dependencies to 1100 #119

jinek commented Oct 19, 2024 •

edited

Loading

tomlm commented Oct 26, 2024

jinek commented Oct 26, 2024 •

edited

Loading

tomlm left a comment

tomlm commented Oct 27, 2024 •

edited

Loading

tomlm commented Oct 29, 2024

jinek commented Oct 29, 2024

coderabbitai bot commented Oct 29, 2024 •

edited

Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

jinek commented Oct 29, 2024

105 choredeps upgrade avalonia dependencies to 1100 #119

105 choredeps upgrade avalonia dependencies to 1100 #119

Conversation

jinek commented Oct 19, 2024 • edited Loading

tomlm commented Oct 26, 2024

jinek commented Oct 26, 2024 • edited Loading

tomlm left a comment

Choose a reason for hiding this comment

tomlm commented Oct 27, 2024 • edited Loading

tomlm commented Oct 29, 2024

jinek commented Oct 29, 2024

coderabbitai bot commented Oct 29, 2024 • edited Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

jinek commented Oct 29, 2024

jinek commented Oct 19, 2024 •

edited

Loading

jinek commented Oct 26, 2024 •

edited

Loading

tomlm commented Oct 27, 2024 •

edited

Loading

coderabbitai bot commented Oct 29, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)