tomlm/storageProvider_CA2007_2

Directory.Build.props

@@ -9,6 +9,7 @@
         <Authors>https://github.com/jinek/Consolonia/graphs/contributors</Authors>
         <Description>Text User Interface implementation of Avalonia UI (GUI Framework)</Description>
         <Copyright>Copyright © Evgeny Gorbovoy 2021 - 2022</Copyright>
+        <NoWarn>AVA3001</NoWarn>
     </PropertyGroup>
     <PropertyGroup>
         <AvaloniaVersion>11.0.9</AvaloniaVersion>

src/.editorconfig

@@ -74,6 +74,7 @@ dotnet_diagnostic.ca1043.severity = none # todo: why not to use indexer rather t
 dotnet_diagnostic.ca1814.severity = none # sometimes we need rectangle array
 dotnet_diagnostic.ca1058.severity = none # check why new documentation warns not to derive from ApplicationException. The purpose of last is to distinguish system exceptions like OOM, AssemblyLoadException etc from application logic
 dotnet_diagnostic.ca2000.severity = none # exceptions which are listed in the rule can be applied to any type
+dotnet_diagnostic.CA2007.severity = none # we are assuming task continuation thread is fine by default
 dotnet_diagnostic.ca2213.severity = none # keeping field does not mean necessarity to dispose - it can be dispose somwhere else
 dotnet_diagnostic.ca2248.severity = none # https://github.com/dotnet/roslyn-analyzers/issues/4432
 dotnet_diagnostic.ca1062.severity = none # we are fine with NRE - no need for additional checks

src/Consolonia.Core/Consolonia.Core.csproj

@@ -1,8 +1,5 @@
 <Project Sdk="Microsoft.NET.Sdk">
-    <Import Project="$([MSBuild]::GetPathOfFileAbove('Directory.Core.Build.props', '$(MSBuildThisFileDirectory)../'))" />
-    <PropertyGroup>
-        <NoWarn>CA2007;</NoWarn>
-    </PropertyGroup>
+    <Import Project="$([MSBuild]::GetPathOfFileAbove('Directory.Core.Build.props', '$(MSBuildThisFileDirectory)../'))" />    
     <ItemGroup>
         <AvaloniaXaml Remove="Controls\FileOpen\**" />
         <Compile Remove="Controls\FileOpen\**" />

src/Consolonia.GuiCS/Consolonia.GuiCS.csproj

@@ -3,6 +3,5 @@
     <WarningsAsErrors>false</WarningsAsErrors>
     <EnforceCodeStyleInBuild>false</EnforceCodeStyleInBuild>
     <EnableNETAnalyzers>false</EnableNETAnalyzers>
-    <NoWarn>CA2007;</NoWarn>
   </PropertyGroup>
 </Project>

src/Consolonia.NUnit/Consolonia.NUnit.csproj

@@ -4,7 +4,6 @@
 
     <PropertyGroup>
         <IsPackable>true</IsPackable>
-        <NoWarn>CA2007;</NoWarn>
     </PropertyGroup>
 
     <ItemGroup>

src/Consolonia.PlatformSupport/Consolonia.PlatformSupport.csproj

@@ -1,10 +1,6 @@
 <Project Sdk="Microsoft.NET.Sdk">
     <Import Project="$([MSBuild]::GetPathOfFileAbove('Directory.Core.Build.props', '$(MSBuildThisFileDirectory)../'))" />
 
-    <PropertyGroup>
-        <NoWarn>CA2007;</NoWarn>
-    </PropertyGroup>
-
     <ItemGroup>
         <ProjectReference Include="..\Consolonia.Core\Consolonia.Core.csproj" />
         <ProjectReference Include="..\Consolonia.GuiCS\Consolonia.GuiCS.csproj" />        

src/Consolonia.Themes.TurboVision/Consolonia.Themes.TurboVision.csproj

@@ -2,10 +2,6 @@
 
     <Import Project="$([MSBuild]::GetPathOfFileAbove('Directory.Core.Build.props', '$(MSBuildThisFileDirectory)../'))" />
 
-    <PropertyGroup>
-        <NoWarn>CA2007;</NoWarn>
-    </PropertyGroup>
-
     <ItemGroup>
       <PackageReference Include="Avalonia" Version="$(AvaloniaVersion)" />
     </ItemGroup>

src/Tests/Consolonia.Core.Tests/Consolonia.Core.Tests.csproj

@@ -4,7 +4,6 @@
 
     <PropertyGroup>
         <IsPackable>false</IsPackable>
-        <NoWarn>CA2007;</NoWarn>
     </PropertyGroup>
 
 

src/Tests/Consolonia.Core.Tests/StorageTests.cs

@@ -1,6 +1,6 @@
-#pragma warning disable CA2007 // Consider calling ConfigureAwait on the awaited task
 // ReSharper disable PossibleNullReferenceException
 // ReSharper disable ConstantConditionalAccessQualifier
+
 using System;
 using System.Globalization;
 using System.IO;

src/Tests/Consolonia.Gallery.Tests/Consolonia.Gallery.Tests.csproj

@@ -2,7 +2,6 @@
 
     <PropertyGroup>
         <IsPackable>false</IsPackable>
-        <NoWarn>CA2007;</NoWarn>
     </PropertyGroup>
 
     <ItemGroup>