fix exception in menuitem extension

[tomlm]

Fix for #151

Summary by CodeRabbit

• Bug Fixes

  • Improved error handling by adding a null check for the focused control, preventing potential runtime errors.

• New Features

  • Enhanced robustness of the menu control by ensuring operations are only executed when the focused control is not null.

[coderabbitai]

Walkthrough

The changes made to the MenuExtensions class in the Consolonia.Themes.TurboVision.Templates.Controls.Helpers namespace include the addition of a null check for the focusedControl variable. This ensures that properties are not accessed on a null reference, improving error handling. The retrieval of focusedTree and menuItems is now encapsulated within this null check, while the event handling for FocusOnLoadProperty remains unchanged. Overall, the control flow and event handling structure are preserved, maintaining the existing functionality.

Changes

File Path	Change Summary
src/Consolonia.Themes.TurboVision/Templates/Controls/Helpers/MenuExtensions.cs	Added null check for focusedControl to prevent null reference exceptions; encapsulated retrieval of focusedTree and menuItems within the null check; maintained existing event handling logic.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant MenuExtensions
    participant FocusedControl

    User->>MenuExtensions: Attach to Visual Tree
    MenuExtensions->>FocusedControl: Check if focusedControl is not null
    alt focusedControl is not null
        MenuExtensions->>FocusedControl: GetLogicalAncestors()
        MenuExtensions->>MenuItems: Retrieve menu items
    else focusedControl is null
        MenuExtensions->>User: No action taken
    end

Loading

🐰 "In the code where rabbits hop,
Null checks make the errors stop.
Focused controls, safe and sound,
Menu items all around!
With each change, we dance and play,
Robust code is here to stay!" 🐇

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between f320cab and feaf175.

📒 Files selected for processing (1)

• src/Consolonia.Themes.TurboVision/Templates/Controls/Helpers/MenuExtensions.cs (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• src/Consolonia.Themes.TurboVision/Templates/Controls/Helpers/MenuExtensions.cs

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)

src/Consolonia.Themes.TurboVision/Templates/Controls/Helpers/MenuExtensions.cs (1)

42-50: Consider adding debug logging for null focus cases

While the null check prevents the exception, it might be helpful to log when focusedControl is null for debugging purposes. Additionally, consider whether menu items should be closed when no control has focus.

 if (focusedControl != null)
 {
     var focusedTree = focusedControl.GetLogicalAncestors();
     var menuItems = visual.GetLogicalAncestors().OfType<MenuItem>();

     foreach (MenuItem menuItem in menuItems.Where(item => !focusedTree.Contains(item))
                  .ToArray())
         menuItem.Close();
+} else {
+    // Consider adding debug logging here
+    Logger.Debug("No control has keyboard focus");
+    
+    // Consider whether to close all menu items when nothing has focus
+    // var menuItems = visual.GetLogicalAncestors().OfType<MenuItem>();
+    // foreach (MenuItem menuItem in menuItems.ToArray())
+    //     menuItem.Close();
 }

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between ad9bc55 and f320cab.

📒 Files selected for processing (1)

• src/Consolonia.Themes.TurboVision/Templates/Controls/Helpers/MenuExtensions.cs (1 hunks)

🔇 Additional comments (1)

src/Consolonia.Themes.TurboVision/Templates/Controls/Helpers/MenuExtensions.cs (1)

42-50: LGTM! Null check prevents NullReferenceException

The null check for focusedControl properly prevents the NullReferenceException that would occur when calling GetLogicalAncestors() on a null reference. The fix maintains the original menu closing behavior when a control has focus.