fix for issue #189 slow startup

[tomlm]

This is less goofy and now it starts in <1s instead of 10seconds. #189

[coderabbitai]

📝 Walkthrough

📝 Walkthrough

Walkthrough

The pull request introduces modifications to the InputLessDefaultNetConsole class within the Consolonia.Core.Infrastructure namespace, specifically focusing on the handling of complex emoji support. The SupportsComplexEmoji property has been simplified to return the value of _supportEmoji, defaulting to false if _supportEmoji is null. The detection logic for _supportEmoji has been relocated to the PrepareConsole method, which now checks the cursor position before and after rendering a test emoji to determine if complex emoji rendering is supported. This method sets _supportEmoji based on whether the cursor moved two positions, indicating successful rendering of composite surrogate pairs. The detailed comments and previous logic in the SupportsComplexEmoji property have been removed to streamline the property into a simple getter. The overall structure of the class remains unchanged, with no modifications to other public methods or properties.

Possibly related PRs

• CA1303 disabled #157: This PR also modifies the InputLessDefaultNetConsole class, specifically enhancing the detection logic for complex emoji rendering, which is directly related to the changes made in the main PR regarding the SupportsComplexEmoji property and the PrepareConsole method.

Suggested labels

CI, low priority

Suggested reviewers

• jinek

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between aed3cbb and 292771e.

📒 Files selected for processing (1)

• src/Consolonia.Core/Infrastructure/InputLessDefaultNetConsole.cs (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• src/Consolonia.Core/Infrastructure/InputLessDefaultNetConsole.cs

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)

src/Consolonia.Core/Infrastructure/InputLessDefaultNetConsole.cs (1)

161-169: Efficient emoji detection implementation with room for improvement

The implementation is clever and efficient, testing emoji support during initialization. However, consider adding error handling:

-            (int left, int top) = Console.GetCursorPosition();
-            WriteText(
-                $"{Esc.Foreground(Colors.Transparent)}{Esc.Background(Colors.Transparent)}{TestEmoji}"); 
-             (int left2, _) = Console.GetCursorPosition();
-            _supportEmoji = left2 - left == 2;
-             Console.SetCursorPosition(left, top);
+            try
+            {
+                (int left, int top) = Console.GetCursorPosition();
+                WriteText(
+                    $"{Esc.Foreground(Colors.Transparent)}{Esc.Background(Colors.Transparent)}{TestEmoji}");
+                (int left2, _) = Console.GetCursorPosition();
+                _supportEmoji = left2 - left == 2;
+                Console.SetCursorPosition(left, top);
+            }
+            catch (IOException)
+            {
+                // Fallback if cursor operations fail
+                _supportEmoji = false;
+            }

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between a74b10d and aed3cbb.

📒 Files selected for processing (1)

• src/Consolonia.Core/Infrastructure/InputLessDefaultNetConsole.cs (3 hunks)

🔇 Additional comments (2)

src/Consolonia.Core/Infrastructure/InputLessDefaultNetConsole.cs (2)

50-50: Performance improvement: Cached emoji support detection

Good optimization. Changed from repeated detection to cached result, which helps reduce startup time and improves runtime performance.

---

161-169: Verify startup time improvement

The changes look promising for improving startup time. Let's verify the claimed improvement from 10s to 1s.