Fix dialog title #245

tomlm · 2025-01-04T00:44:37Z

MessageBox shadow was broken
Fixed title that overlapped close button
Added a bit of turbovision pizazz to double line with ==| text |===

add border chars around it to make it look nicer.

coderabbitai · 2025-01-04T00:51:46Z

📝 Walkthrough

Walkthrough

The pull request introduces changes to two distinct areas of the Consolonia project. In the DrawingContextImpl.cs file, the DrawGeometry method has been modified to improve pen handling during drawing operations. The changes ensure that a valid pen is always available by creating a new Pen instance when the input pen is null. The method now more robustly extracts color and line style information, with enhanced logic for managing drawing parameters.

In the DialogWindow.axaml file, the XAML template for the DialogWindow control has been restructured. The layout has been transformed from a nested Border and multiple StackPanel elements to a more streamlined Grid-based layout. This reorganization maintains the original functionality while improving the visual structure of the control, with refined positioning of icons, title, and close button.

Possibly related PRs

Fix strikethrough implementation #134: Modifies DrawLineInternal method in DrawingContextImpl class, sharing similar drawing logic
Implement quad pixels characters for drawing bitmaps #137: Makes extensive changes to DrawingContextImpl class, specifically the DrawBitmap method
null LineBrush is ignored (like other transparent stuff) #210: Updates DrawRectangle method in DrawingContextImpl class, involving drawing operations
fix caret cursor #212: Enhances DrawingContextImpl class with caret rendering functionality

Suggested labels

bug

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d6408f0 and 09b6696.

📒 Files selected for processing (2)

src/Consolonia.Core/Drawing/DrawingContextImpl.cs (1 hunks)
src/Consolonia.Themes/Templates/Controls/DialogWindow.axaml (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (2)

src/Consolonia.Themes/Templates/Controls/DialogWindow.axaml
src/Consolonia.Core/Drawing/DrawingContextImpl.cs

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (5)

src/Consolonia.Core/Text/Esc.cs (1)

47-53: Consider adding usage documentation for the newly introduced mouse-tracking constants.

While these new constants are correctly specified ANSI escape codes, it would be valuable to include short doc comments explaining their intended usage scenarios and potential terminal compatibility caveats. This can help maintainers or contributors easily grasp their functionality.

src/Consolonia.Themes/Templates/Controls/DialogWindow.axaml (4)

45-46: Consider consolidating into a single grid definition if feasible.
Currently, we have a nested <Grid ColumnDefinitions="*"> containing another <Grid ColumnDefinitions="* Auto"> right beneath it. If there's no specific need for two grid layers, you may simplify the layout into a single grid definition to reduce nesting and keep the XAML more maintainable.

51-53: Check for font compatibility with special Unicode characters.
The added "╡" and "╞" might not render in all fonts or terminals. Make sure they appear correctly under the project's supported environments.

56-71: Optional: add a tooltip for the close button.
Providing a tooltip (e.g., "Close") can improve accessibility and clarity for users unfamiliar with the "×" icon.

74-86: Fallback strategy for double-line borders.
If some environments do not correctly render double-line characters, consider a fallback or a property-based toggle to handle graceful degradation.

Do you want me to propose a fallback mechanism using style triggers?

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d073eae and d6408f0.

📒 Files selected for processing (3)

src/Consolonia.Core/Drawing/DrawingContextImpl.cs (1 hunks)
src/Consolonia.Core/Text/Esc.cs (1 hunks)
src/Consolonia.Themes/Templates/Controls/DialogWindow.axaml (1 hunks)

🔇 Additional comments (2)

src/Consolonia.Themes/Templates/Controls/DialogWindow.axaml (1)

47-54: Verify the data-binding for IsVisible on the Icon.
The IsVisible="{Binding Icon.Length}" binding expects a boolean, whereas Icon.Length is numeric. For reliability, consider a converter binding (e.g., "Icon.Length > 0") to ensure a proper boolean is supplied.

src/Consolonia.Core/Drawing/DrawingContextImpl.cs (1)

162-162: Confirm intended behavior of defaulting to a new pen.
Previously, a null pen meant no stroke. Now, you create a default pen with thickness 1. This changes the drawing logic, potentially introducing unintended strokes. Ensure this new behavior aligns with design goals.

Co-authored-by: <[email protected]>

jinek · 2025-01-04T07:58:33Z

src/Consolonia.Core/Drawing/DrawingContextImpl.cs

@@ -159,8 +159,7 @@ public void DrawGeometry(IBrush brush, IPen pen, IGeometryImpl geometry)
                    // if we have strokes to draw
                    if (streamGeometry.Strokes.Count > 0)
                    {
-                        if (pen == null || pen.Thickness == 0)
-                            return;
+                        pen = pen ?? new Pen(brush);


What is the case when pen is not passed?

tomlm added 3 commits January 3, 2025 11:40

add escape codes for mouse tracking

af351c8

fix dialog title bar button layout so it doesn't overlap title

dc3972c

add border chars around it to make it look nicer.

cleaned up dialog layout and fixed shadow

d6408f0

coderabbitai bot reviewed Jan 4, 2025

View reviewed changes

Merge branch 'main' into tomlm/boxSymbol

bb86b63

tomlm enabled auto-merge (squash) January 4, 2025 00:52

tomlm changed the title ~~Fix messagebox~~ Fix dialog title Jan 4, 2025

Automated JetBrains cleanup

09b6696

Co-authored-by: <[email protected]>

tomlm requested a review from jinek January 4, 2025 01:24

jinek approved these changes Jan 4, 2025

View reviewed changes

tomlm merged commit f746ff2 into main Jan 4, 2025
3 checks passed

tomlm deleted the tomlm/boxSymbol branch January 4, 2025 07:57

jinek reviewed Jan 4, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix dialog title #245

Fix dialog title #245

tomlm commented Jan 4, 2025

coderabbitai bot commented Jan 4, 2025 •

edited

Loading

Walkthrough

Possibly related PRs

Suggested labels

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

coderabbitai bot left a comment

jinek Jan 4, 2025

Fix dialog title #245

Fix dialog title #245

Conversation

tomlm commented Jan 4, 2025

coderabbitai bot commented Jan 4, 2025 • edited Loading

Walkthrough

Possibly related PRs

Suggested labels

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

coderabbitai bot left a comment

Choose a reason for hiding this comment

jinek Jan 4, 2025

Choose a reason for hiding this comment

coderabbitai bot commented Jan 4, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)