Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate plugins to new repositories #176

Open
mpapis opened this issue Sep 4, 2014 · 15 comments
Open

migrate plugins to new repositories #176

mpapis opened this issue Sep 4, 2014 · 15 comments

Comments

@mpapis
Copy link
Collaborator

mpapis commented Sep 4, 2014

follow up for #152, as we have https://github.com/pre-commit-plugins we should consider separating plugins to separate repositories.

@jish I would start with checks that do not have any dependencies and are not included by default .. did not had time to look which ones fit best

@mpapis
Copy link
Collaborator Author

mpapis commented Sep 6, 2014

something like #164 would be a good point to start, @jish?

@jish
Copy link
Owner

jish commented Sep 6, 2014

Yea, I agree. The PHP and Go checks seem like good candidates for plugins.

@mpapis
Copy link
Collaborator Author

mpapis commented Sep 12, 2014

@jish in https://github.com/pre-commit-plugins I get You don't appear to have permission to create repositories for this organization. Sorry about that.

mpapis added a commit that referenced this issue Sep 13, 2014
@mpapis
Copy link
Collaborator Author

mpapis commented Sep 13, 2014

and I can not transfer rights of https://github.com/mpapis/pre-commit-php because of You don't have admin rights to pre-commit-plugins

@jish
Copy link
Owner

jish commented Oct 1, 2014

@mpapis I changed the access controls on pre-commit-plugins, can you check if you have more permission now?

https://github.com/pre-commit-plugins/pre-commit-php

@mpapis
Copy link
Collaborator Author

mpapis commented Oct 1, 2014

can not push to the new repo:

ERROR: Permission to pre-commit-plugins/pre-commit-php.git denied to mpapis.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights and the repository exists.

@mpapis
Copy link
Collaborator Author

mpapis commented Oct 1, 2014

go to https://github.com/orgs/pre-commit-plugins/teams and add the new repo to core team - or add me to Owners/admins

@jish
Copy link
Owner

jish commented Oct 1, 2014

try now? :x

@mpapis
Copy link
Collaborator Author

mpapis commented Oct 1, 2014

it worked :)

@mpapis
Copy link
Collaborator Author

mpapis commented Oct 1, 2014

and the gem is here https://rubygems.org/gems/pre-commit-php

@mpapis
Copy link
Collaborator Author

mpapis commented Oct 1, 2014

and all the badges are online => https://github.com/pre-commit-plugins/pre-commit-php#readme

@mpapis
Copy link
Collaborator Author

mpapis commented Oct 1, 2014

and @jish can push the gem now too: http://rubygems.org/gems/pre-commit-php

jish added a commit that referenced this issue Oct 21, 2014
@mpapis
Copy link
Collaborator Author

mpapis commented Oct 21, 2014

and #180 is merged, the php plugin will work now outside of the pre-commit gem - it's a good start :)

@mpapis
Copy link
Collaborator Author

mpapis commented Jan 7, 2015

@jish I would say this is one of the steps towards 1.0.0 what do you think?

@jish
Copy link
Owner

jish commented Jan 7, 2015

Yea, definitely :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants