-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update code format with newer clang-format
tool
#67
Update code format with newer clang-format
tool
#67
Conversation
Hi @joelguittet, I hope that you don't find this PR too intrusive. What do you think about updating the tool? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a large PR but looks good improvement for readability of the code. To be honest I don't know why it was not properly aligned with the previous clang version...
Can you simply rebase on top of the master branch so that we keep a clean git history ? Thanks
Additionally if possible can you update the commit title to something like "ci : xxx". I see you do that for other mender stuff such as mendersoftware/meta-mender@bf90a12. This is not a strong rule but I think it can help in the future to easily grep the git log, just in case we need. Thanks a lot! |
f0df0c7
to
9bf91c8
Compare
Thanks @joelguittet
Done
Done. Although I decided to use In Mender we require Conventional Commits formatting (you can see the spec here) but I try to follow the existing commit style when I contribute to Open Source projects, so I didn't want to "impose" that here. However I am happy to see that you see value on it! |
Thanks and a gig sorry, I will ask you to rebase again :-( I have reverted the deployment api modification in the meantime. |
Ubuntu 20.04 used in CI was getting a bit dated. Updated CI job with latest Ubuntu LTS release (with newer `clang-format`) and format all the code accordingly. Signed-off-by: Lluis Campos <[email protected]>
9bf91c8
to
02e0531
Compare
Rebased now. Sorry to be slow - I am on vacation and I do GitHub only on bad weather days ☔ |
Quality Gate passedIssues Measures |
All good for me @lluiscampos, thanks for the updates! Merging now. |
Ubuntu 20.04 used in CI was getting a bit dated.
Updated CI job with latest Ubuntu LTS release (with newer
clang-format
) and format all the code accordingly.