Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: add evenness metrics #575

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

colinbrislawn
Copy link

@colinbrislawn colinbrislawn commented Jan 27, 2016

This should now to ready to merge.
Eventually, this will resolve #568.

@colinbrislawn
Copy link
Author

colinbrislawn commented Jan 28, 2016

TODO:

  • Get feedback on naming metrics and incorporate that
  • Add these metrics to vignettes
  • Get plots to work
  • Get Travis build to work

@colinbrislawn
Copy link
Author

This build currently finishes, but is marked as failing due to three warning.

Status: 3 WARNINGs, 8 NOTEs
See
  ‘/home/travis/build/joey711/phyloseq/phyloseq.Rcheck/00check.log’
for details.

@joey711 Any ideas?

@colinbrislawn
Copy link
Author

These are the three warning detected. I didn't change these files so I think these were standing problems before this PR. How should I resolve these?

checking whether package ‘phyloseq’ can be installed ... WARNING
Found the following significant warnings:
  Warning: replacing previous import by ‘ggplot2::Position’ when loading ‘phyloseq’
  Warning: replacing previous import by ‘scales::alpha’ when loading ‘phyloseq’

[Lots of notes, which I omit]
[...]

checking Rd cross-references ... WARNING
Missing link or links in documentation object 'import_uparse.Rd':
  ‘[data.table]{read.table}’

Missing link or links in documentation object 'psmelt.Rd':
  ‘ggplot2’

See section 'Cross-references' in the 'Writing R Extensions' manual.
 checking Rd \usage sections ... WARNING
Undocumented arguments in documentation object 'microbio_me_qiime'
  ‘ext’ ‘parsef’ ‘...’

Undocumented arguments in documentation object 'rarefy_even_depth'
  ‘trimOTUs’

Functions with \usage entries need to have the appropriate \alias
entries, and all their arguments documented.

@colinbrislawn
Copy link
Author

How does this look @joey711? How should I add these to the vignettes?

@colinbrislawn
Copy link
Author

@joey711 Does this look ready to merge?

@colinbrislawn
Copy link
Author

I could update this make use of the current build process, and to show examples in the vignettes on the new website.

@colinbrislawn
Copy link
Author

@joey711 Are you still accepting PRs for this project or you actively developing SecondGenomeR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Additional metrics in estimate_richness
1 participant